Skip to content

[improvement](FQDN)Remove excess code - #19638

Merged
morningman merged 1 commit into
apache:masterfrom
zddr:fqdn_unusecode
May 16, 2023
Merged

[improvement](FQDN)Remove excess code#19638
morningman merged 1 commit into
apache:masterfrom
zddr:fqdn_unusecode

Conversation

@zddr

@zddrzddr commented May 15, 2023

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.
Inherited from:#19123

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zddr

zddr commented May 15, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningmanmorningman self-assigned this May 15, 2023
@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label May 15, 2023
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@morningman
morningman merged commit 8ec1866 into apache:masterMay 16, 2023
@zddrzddr mentioned this pull request May 23, 2023
3 tasks
@zddr
zddr deleted the fqdn_unusecode branch March 28, 2024 02:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@zddr@morningman