Uh oh!
There was an error while loading. Please reload this page.
[Bug-fix][Broker-load] Fix the bug of the label already exists when the txn has been finished - #1992
Merged
Merged
Conversation
EmmyMiao87
commented
Oct 16, 2019
ContributorAuthor
EmmyMiao87force-pushed
the
broker_load_bug
branch
from
October 16, 2019 02:27
ef99804 to
968c3f0Compareimay
reviewed
Oct 16, 2019
| @Override | ||
| protected void executeReplayOnVisible(TransactionState txnState) { | ||
| protected void executeReplayTxnAttachment(TransactionState txnState) { |
Contributor
There was a problem hiding this comment.
Suggested change
| protectedvoidexecuteReplayTxnAttachment(TransactionStatetxnState) { | |
| protectedvoidreplayTxnAttachment(TransactionStatetxnState) { |
| map.put(loadJob.getLabel(), jobs); | ||
| } | ||
| jobs.add(loadJob); | ||
| if (!loadJob.isCompleted()) { |
Contributor
There was a problem hiding this comment.
Add some comment to explain this operation
Contributor
There was a problem hiding this comment.
I think you should use another way to achieve this. When this function is called, Catalog is not ready. However you start to use Catalog's item, this is error-prone.
ContributorAuthor
There was a problem hiding this comment.
The callback need to be add in here. The reason is that the replay of txn maybe use the callback and reload the job state.
imay
requested changes
Oct 16, 2019
| map.put(loadJob.getLabel(), jobs); | ||
| } | ||
| jobs.add(loadJob); | ||
| if (!loadJob.isCompleted()) { |
Contributor
There was a problem hiding this comment.
I think you should use another way to achieve this. When this function is called, Catalog is not ready. However you start to use Catalog's item, this is error-prone.
morningman
requested changes
Oct 16, 2019
morningman
left a comment
Contributor
There was a problem hiding this comment.
Some other questions:
isCommittingandisCancellablevariable in LoadJob.java is confusing. Add some comments.
And it seems thatisCancellableis useless.
| } | ||
| jobs.add(loadJob); | ||
| if (!loadJob.isCompleted()) { | ||
| Catalog.getCurrentGlobalTransactionMgr().getCallbackFactory().addCallback(loadJob); |
Contributor
There was a problem hiding this comment.
This should be done in prepareJobs();
| writeLock(); | ||
| try { | ||
| executeReplayOnVisible(txnState); | ||
| executeReplayTxnAttachment(txnState); |
Contributor
There was a problem hiding this comment.
I think the name executeReplayTxnAttachment should be changed.
Or calling a "replay" method in "non-replay" method is weird
…he txn has been finished If FE is restarted between txn committed and visible, the load job will be rescheduled and failed with label already exists. The reason is that there are inconsistency between transaction of load job and meta of load job. So, the replay of the txn attachment need to be done in function replayOnCommitted. The load job state and progress is correct after that.
EmmyMiao87force-pushed
the
broker_load_bug
branch
from
October 16, 2019 06:49
f4f051e to
4c60657Comparewuyunfeng pushed a commit
to wuyunfeng/incubator-doris
that referenced
this pull request
Oct 22, 2019
…he txn has been finished (apache#1992) If FE is restarted between txn committed and visible, the load job will be rescheduled and failed with label already exists. The reason is that there are inconsistency between transaction of load job and meta of load job. So, the replay of the txn attachment need to be done in function replayOnCommitted. The load job state and progress is correct after that.
morningman pushed a commit
to morningman/doris
that referenced
this pull request
Dec 10, 2019
…he txn has been finished (apache#1992) If FE is restarted between txn committed and visible, the load job will be rescheduled and failed with label already exists. The reason is that there are inconsistency between transaction of load job and meta of load job. So, the replay of the txn attachment need to be done in function replayOnCommitted. The load job state and progress is correct after that.
swjtu-zhanglei pushed a commit
to swjtu-zhanglei/incubator-doris
that referenced
this pull request
Jul 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If FE is restarted between txn committed and visible, the load job will be rescheduled and failed with label already exists.
The reason is that there are inconsistency between transaction of load job and meta of load job.
So, the replay of the txn attachment need to be done in function replayOnCommitted.
The load job state and progress is correct after that.