Skip to content

[fix](hashtable) Check query cancel status during build hash table - #19970

Merged
yiguolei merged 1 commit into
apache:masterfrom
xinyiZzz:20230524_fix_join_build_cancel
May 24, 2023
Merged

[fix](hashtable) Check query cancel status during build hash table#19970
yiguolei merged 1 commit into
apache:masterfrom
xinyiZzz:20230524_fix_join_build_cancel

Conversation

@xinyiZzz

@xinyiZzzxinyiZzz commented May 23, 2023•
edited by yiguolei
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

should cancel query during hash table build stage if the query is cancelled.

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions

github-actionsBot commented May 23, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xinyiZzz

xinyiZzz commented May 23, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

yiguolei
yiguolei reviewed May 24, 2023
View reviewed changes
Comment threadbe/src/vec/exec/vset_operation_node.cpp Outdated
yiguolei
yiguolei reviewed May 24, 2023
View reviewed changes
Comment threadbe/src/vec/exec/join/vhash_join_node.cpp Outdated
yiguolei
yiguolei reviewed May 24, 2023
View reviewed changes
Comment threadbe/src/vec/exec/join/vhash_join_node.cpp Outdated
yiguolei
yiguolei reviewed May 24, 2023
View reviewed changes
Comment threadbe/src/vec/exec/join/vhash_join_node.cpp Outdated
@xinyiZzz
xinyiZzzforce-pushed the 20230524_fix_join_build_cancel branch from 6a49735 to c97ca37CompareMay 24, 2023 02:15
@github-actions

github-actionsBot commented May 24, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

yiguolei
yiguolei approved these changes May 24, 2023
View reviewed changes

@yiguoleiyiguolei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label May 24, 2023
@github-actions

github-actionsBot commented May 24, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented May 24, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yiguolei

yiguolei commented May 24, 2023

Copy link
Copy Markdown
Contributor

run buildall

@yiguolei
yiguolei merged commit 14b4c7a into apache:masterMay 24, 2023
xinyiZzz added a commit to xinyiZzz/incubator-doris that referenced this pull request Jun 6, 2023
@xinyiZzz
[fix](hashtable) Check query cancel status during build hash tableap…
77e4515
…ache#19970
should cancel query during hash table build stage if the query is cancelled.
@xinyiZzzxinyiZzz mentioned this pull request Jun 6, 2023
Merged
yiguolei pushed a commit that referenced this pull request Jun 7, 2023
@xinyiZzz
[fix](hashtable) Check query cancel status during build hash table#1…
2fd0bf4
…9970 (#20512)
should cancel query during hash table build stage if the query is cancelled.
Issue Number: close #xxx
pick #19970
mongo360 pushed a commit to mongo360/doris that referenced this pull request Jul 12, 2023
@xinyiZzzcaiconghui1
[fix](hashtable) Check query cancel status during build hash tableap…
80c314d
…ache#19970 (apache#20512)
should cancel query during hash table build stage if the query is cancelled.
Issue Number: close #xxx
pick apache#19970
swjtu-zhanglei added a commit to swjtu-zhanglei/incubator-doris that referenced this pull request Jul 25, 2023
@swjtu-zhanglei@xinyiZzz
Pick "[fix](hashtable) Check query cancel status during build hash ta…
35b5e8c
…ble apache#19970 (apache#20512)" (apache#1900)
should cancel query during hash table build stage if the query is cancelled.
pick apache#19970
Co-authored-by: Xinyi Zou <zouxinyi02@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguoleiyiguoleiyiguolei approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.area/vectorizationdev/1.2.5-mergedneed-cherry-pickreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xinyiZzz@yiguolei@morningman