Uh oh!
There was an error while loading. Please reload this page.
[Feature][Fix](multi-catalog) Implements transactional hive full acid tables. - #20679
Merged
Conversation
kaka11chen
commented
Jun 11, 2023
ContributorAuthor
run buildall |
5 tasks
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
kaka11chen
commented
Jun 12, 2023
ContributorAuthor
run buildall |
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
| if (columnsFromPath == null || columnsFromPath.isEmpty()) { | ||
| return Collections.emptyList(); | ||
| } | ||
| int pathCount = isACID ? 3 : 2; |
Contributor
There was a problem hiding this comment.
Add comment explain 3 and 2, better give an example
| } | ||
| } | ||
| private List<Split> splitFile(Path path, long blockSize, BlockLocation[] blockLocations, long length, |
Contributor
There was a problem hiding this comment.
Better to find a way to extract the common part of splitFile and the same method defined in FileScanNode, or it is hard to maintain.
kaka11chen
commented
Jun 12, 2023
ContributorAuthor
run buildall |
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
kaka11chen
commented
Jun 12, 2023
ContributorAuthor
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
After supporting insert-only transactional hive full acid tables #19518, #19419, this PR support transactional hive full acid tables.
Further comments
Regression test only test with hive2 transactional hive full acid tables now, because the docker image version is hive 2.x, will add hive 3.x. docker later.
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...