Skip to content

[improvement](multi-catalog)add last sync time for external catalog - #21873

Merged
morningman merged 12 commits into
apache:masterfrom
zddr:ctr_time
Jul 21, 2023
Merged

[improvement](multi-catalog)add last sync time for external catalog#21873
morningman merged 12 commits into
apache:masterfrom
zddr:ctr_time

Conversation

@zddr

@zddrzddr commented Jul 17, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #xxx

which operation can update this time:

1.when refresh catalog,lastUpdateTime of catalog will be update
2.when refresh db,lastUpdateTime of db will be update
3.when reload table schema to cache,lastUpdateTime of dbtable will be update
4.when receive add/drop table event,lastUpdateTime of db will be update
5.when receive alter table event,lastUpdateTime of table will be update

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

morningman
morningman reviewed Jul 17, 2023
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/analysis/ShowCatalogStmt.java Outdated
morningman
morningman reviewed Jul 17, 2023
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/common/proc/DbsProcDir.java Outdated
Comment threadfe/fe-core/src/main/java/org/apache/doris/common/proc/TablesProcDir.java Outdated
Comment threadfe/fe-core/src/main/java/org/apache/doris/datasource/CatalogMgr.java Outdated
@morningman

morningman commented Jul 17, 2023

Copy link
Copy Markdown
Contributor

Need to list which operation can update this time. For exmple:
refresh ? sync hms event？FE restart?

And please add test case for it.

@morningmanmorningman added the dev/2.0.0 2.0.0 release label Jul 17, 2023
@zddr
zddr requested a review from morningmanJuly 17, 2023 14:29
@zddr

zddr commented Jul 17, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

morningman
morningman previously approved these changes Jul 17, 2023
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jul 17, 2023
@github-actions

github-actionsBot commented Jul 17, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Jul 17, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@zddr

zddr commented Jul 18, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Jul 18, 2023
morningman
morningman previously approved these changes Jul 19, 2023
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jul 19, 2023
@github-actions

github-actionsBot commented Jul 19, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

wsjz
wsjz reviewed Jul 19, 2023
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/common/proc/TablesProcDir.java Outdated
Comment threadfe/fe-core/src/main/java/org/apache/doris/datasource/CatalogIf.java
Comment threadfe/fe-core/src/main/java/org/apache/doris/datasource/CatalogMgr.java Outdated
Comment threadfe/fe-core/src/main/java/org/apache/doris/common/proc/DbsProcDir.java Outdated
@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Jul 19, 2023
@zddr
zddr requested review from morningman and wsjzJuly 19, 2023 03:12
@zddr

zddr commented Jul 19, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

hello-stephen commented Jul 19, 2023

Copy link
Copy Markdown
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 51.59 seconds
stream load tsv: 510 seconds loaded 74807831229 Bytes, about 139 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17170196357 Bytes

wsjz
wsjz approved these changes Jul 19, 2023
View reviewed changes

@wsjzwsjz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

morningman
morningman approved these changes Jul 20, 2023
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jul 20, 2023
@github-actions

github-actionsBot commented Jul 20, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@morningman
morningman merged commit 0b2b1cb into apache:masterJul 21, 2023
@xiaokangxiaokang added dev/2.0.0-merged and removed dev/2.0.0 2.0.0 release labels Jul 21, 2023
xiaokang pushed a commit that referenced this pull request Jul 21, 2023
@zddr@xiaokang
[improvement](multi-catalog)add last sync time for external catalog (#…
8530065
…21873)
which operation can update this time:
1.when refresh catalog,lastUpdateTime of catalog will be update
2.when refresh db,lastUpdateTime of db will be update
3.when reload table schema to cache,lastUpdateTime of dbtable will be update
4.when receive add/drop table event,lastUpdateTime of db will be update
5.when receive alter table event,lastUpdateTime of table will be update
This was referenced Sep 9, 2023
Merged
Merged
@zddr
zddr deleted the ctr_time branch March 28, 2024 02:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningmanmorningmanmorningman approved these changes
+1 more reviewer
@wsjzwsjzwsjz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.0-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zddr@morningman@hello-stephen@wsjz@xiaokang