Uh oh!
There was an error while loading. Please reload this page.
[Enhancement](delete) eliminate reading the old values of non-key columns for delete stmt - #22270
Conversation
bobhan1
commented
Jul 26, 2023
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
hello-stephen
commented
Jul 26, 2023
(From new machine)TeamCity pipeline, clickbench performance test result: |
bobhan1
commented
Jul 26, 2023
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
hello-stephen
commented
Jul 26, 2023
(From new machine)TeamCity pipeline, clickbench performance test result: |
bobhan1
commented
Jul 26, 2023
run p0 |
1 similar comment
bobhan1
commented
Jul 26, 2023
run p0 |
bobhan1
commented
Jul 27, 2023
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
bobhan1
commented
Jul 27, 2023
run arm |
hello-stephen
commented
Jul 27, 2023
(From new machine)TeamCity pipeline, clickbench performance test result: |
bobhan1
commented
Jul 27, 2023
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
hello-stephen
commented
Jul 27, 2023
(From new machine)TeamCity pipeline, clickbench performance test result: |
Uh oh!
There was an error while loading. Please reload this page.
bobhan1
commented
Jul 27, 2023
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
hello-stephen
commented
Jul 27, 2023
(From new machine)TeamCity pipeline, clickbench performance test result: |
bobhan1
commented
Jul 28, 2023
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
bobhan1
commented
Jul 28, 2023
run clickbench |
hello-stephen
commented
Jul 28, 2023
(From new machine)TeamCity pipeline, clickbench performance test result: |
…umns for delete stmt (#22270)
…umns for delete stmt in publish phase (apache#38703) apache#22270 should also do in pulish phase
…umns for delete stmt in publish phase (apache#38703) apache#22270 should also do in pulish phase
Proposed changes
Currently, when executing
insert into selectstatement converted from a delete statement, doris will try to read all the values of the non-key columns from the previous rows with the same key in storage layer, which is highly costly and meaningless.For example, for a table with the following schema
and data
after execute some delete statement(which is transformed to
insert into selectstatement) that delete rows with k1=1,2,3, the data with delete_sign column will be likeIt's evitable that it reads lots of useless data. So this PR eliminates the above process and use default or null value to fill the non-key columns when inserting rows with marked delete sign, since the values in these columns are useless and will not be read.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...