Skip to content

[improvement](stats) Catch exception properly - #22503

Merged
englefly merged 1 commit into
apache:masterfrom
Kikyou1997:eh/exception_handle
Aug 3, 2023
Merged

[improvement](stats) Catch exception properly#22503
englefly merged 1 commit into
apache:masterfrom
Kikyou1997:eh/exception_handle

Conversation

@Kikyou1997

Copy link
Copy Markdown
Contributor

Proposed changes

Catch exception instead of throw to caller directly to avoid unexpected interruption of upper logic

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@Kikyou1997

Copy link
Copy Markdown
ContributorAuthor

run buildall

@Kikyou1997

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.5 seconds
stream load tsv: 548 seconds loaded 74807831229 Bytes, about 130 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17161766480 Bytes

@hello-stephen

Copy link
Copy Markdown
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.65 seconds
stream load tsv: 511 seconds loaded 74807831229 Bytes, about 139 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17162400112 Bytes

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 2, 2023
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@englefly
englefly merged commit 27f6e46 into apache:masterAug 3, 2023
xiaokang added a commit that referenced this pull request Aug 11, 2023
@xiaokangxiaokang mentioned this pull request Aug 30, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.1-mergedmerge_conflictreviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Kikyou1997@hello-stephen@englefly@morrySnow@xiaokang