Skip to content

[improvement](transaction) abort txn after be lost heartbeat over 1 min - #22781

Merged
dataroaring merged 1 commit into
apache:masterfrom
yujun777:impr-abort-txn-when-be-lost-heartbeat
Aug 10, 2023
Merged

[improvement](transaction) abort txn after be lost heartbeat over 1 min#22781
dataroaring merged 1 commit into
apache:masterfrom
yujun777:impr-abort-txn-when-be-lost-heartbeat

Conversation

@yujun777

@yujun777yujun777 commented Aug 9, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

Default heartbeat failure time is 5s, it's too sensitive to abort a txn.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@yujun777

yujun777 commented Aug 9, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

hello-stephen commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.02 seconds
stream load tsv: 514 seconds loaded 74807831229 Bytes, about 138 MB/s
stream load json: 22 seconds loaded 2358488459 Bytes, about 102 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162223622 Bytes

dataroaring
dataroaring approved these changes Aug 9, 2023
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 9, 2023
@github-actions

github-actionsBot commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

kaijchen
kaijchen approved these changes Aug 10, 2023
View reviewed changes

@kaijchenkaijchen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, hard-coded value could be a config.

@dataroaring
dataroaring merged commit 35dd787 into apache:masterAug 10, 2023
@wm1581066wm1581066 added the usercase Important user case type label label Aug 12, 2024
yujun777 added a commit to yujun777/doris that referenced this pull request Aug 13, 2024
@yujun777
[improvement](transaction) abort txn when be lost heartbeat over 1 min (
c7353a0
apache#22781)
@yujun777yujun777 mentioned this pull request Aug 13, 2024
Merged
dataroaring pushed a commit that referenced this pull request Aug 14, 2024
@yujun777@sollhui
[branch-2.0](txn) be dead exceeds 5min abort its txns (#22781,#28662,…
eaffb69
…#35342) (#39317)
cherry-pick: #22781, #28662, #35342
---------
Co-authored-by: HHoflittlefish777 <77738092+HHoflittlefish777@users.noreply.github.com>
@xiaokangxiaokang mentioned this pull request Sep 14, 2024
Closed
mongo360 pushed a commit to mongo360/doris that referenced this pull request Dec 11, 2024
@yujun777@sollhui@Baymine
[branch-2.0](txn) be dead exceeds 5min abort its txns (apache#22781,a…
9e321a9
…pache#28662, apache#35342) (apache#39317)
cherry-pick: apache#22781, apache#28662, apache#35342
---------
Co-authored-by: HHoflittlefish777 <77738092+HHoflittlefish777@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaringdataroaringdataroaring approved these changes
+1 more reviewer
@kaijchenkaijchenkaijchen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.15-mergedreviewedusercaseImportant user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yujun777@hello-stephen@kaijchen@dataroaring@liaoxin01@wm1581066