Skip to content

[fix](nereids)bind slot failed because of "default_cluster" - #23008

Merged
englefly merged 1 commit into
apache:masterfrom
englefly:slot-bind
Aug 16, 2023
Merged

[fix](nereids)bind slot failed because of "default_cluster"#23008
englefly merged 1 commit into
apache:masterfrom
englefly:slot-bind

Conversation

@englefly

@engleflyenglefly commented Aug 15, 2023

Copy link
Copy Markdown
Contributor

Proposed changes

slot bind failed for following querys:
select tpch.lineitem.* from lineitem
select tpch.lineitem.l_partkey from lineitem

the unbound slot is tpch.lineitem.l_partkey, but the bounded slot is default_cluster:tpch.lineitem.l_partkey. They are not matched.
we need to ignore default_cluster: when compare dbName

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@englefly

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.95 seconds
stream load tsv: 510 seconds loaded 74807831229 Bytes, about 139 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17162181158 Bytes

@englefly

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.14 seconds
stream load tsv: 509 seconds loaded 74807831229 Bytes, about 140 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17162677169 Bytes

@englefly

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.51 seconds
stream load tsv: 512 seconds loaded 74807831229 Bytes, about 139 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17162113308 Bytes

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 16, 2023
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@englefly
englefly merged commit f1880d3 into apache:masterAug 16, 2023
@englefly
englefly deleted the slot-bind branch August 16, 2023 09:22
xiaokang pushed a commit that referenced this pull request Aug 17, 2023
slot bind failed for following querys:
select tpch.lineitem.* from lineitem
select tpch.lineitem.l_partkey from lineitem
the unbound slot is tpch.lineitem.l_partkey, but the bounded slot is default_cluster:tpch.lineitem.l_partkey. They are not matched.
we need to ignore default_cluster: when compare dbName
airborne12 pushed a commit to airborne12/apache-doris that referenced this pull request Aug 21, 2023

slot bind failed for following querys:
select tpch.lineitem.* from lineitem
select tpch.lineitem.l_partkey from lineitem
the unbound slot is tpch.lineitem.l_partkey, but the bounded slot is default_cluster:tpch.lineitem.l_partkey. They are not matched.
we need to ignore default_cluster: when compare dbName
@xiaokangxiaokang mentioned this pull request Aug 30, 2023
924060929 pushed a commit that referenced this pull request Aug 9, 2024
)
This pr is similar with #23008, ignoring cluster_name in binding when
compare dbname. e.g. in this sql, the "dbname" should be viewed same db
when comparing with "default_cluster:dbname"
```sql
select dbname.test_db_name_ignore_cluster.a from `default_cluster:dbname`.test_db_name_ignore_cluster; ```
feiniaofeiafei added a commit to feiniaofeiafei/doris that referenced this pull request Aug 9, 2024
…che#39114)
This pr is similar with apache#23008, ignoring cluster_name in binding when
compare dbname. e.g. in this sql, the "dbname" should be viewed same db
when comparing with "default_cluster:dbname"
```sql
select dbname.test_db_name_ignore_cluster.a from `default_cluster:dbname`.test_db_name_ignore_cluster; ```
dataroaring pushed a commit that referenced this pull request Aug 11, 2024
)
This pr is similar with #23008, ignoring cluster_name in binding when
compare dbname. e.g. in this sql, the "dbname" should be viewed same db
when comparing with "default_cluster:dbname"
```sql
select dbname.test_db_name_ignore_cluster.a from `default_cluster:dbname`.test_db_name_ignore_cluster; ```
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Aug 14, 2024
…che#39114)
This pr is similar with apache#23008, ignoring cluster_name in binding when
compare dbname. e.g. in this sql, the "dbname" should be viewed same db
when comparing with "default_cluster:dbname"
```sql
select dbname.test_db_name_ignore_cluster.a from `default_cluster:dbname`.test_db_name_ignore_cluster; ```
dataroaring pushed a commit that referenced this pull request Aug 16, 2024
)
This pr is similar with #23008, ignoring cluster_name in binding when
compare dbname. e.g. in this sql, the "dbname" should be viewed same db
when comparing with "default_cluster:dbname"
```sql
select dbname.test_db_name_ignore_cluster.a from `default_cluster:dbname`.test_db_name_ignore_cluster; ```
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
…che#39114)
This pr is similar with apache#23008, ignoring cluster_name in binding when
compare dbname. e.g. in this sql, the "dbname" should be viewed same db
when comparing with "default_cluster:dbname"
```sql
select dbname.test_db_name_ignore_cluster.a from `default_cluster:dbname`.test_db_name_ignore_cluster; ```
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.1-mergedreviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@englefly@hello-stephen@starocean999@morrySnow@xiaokang@morningman