[Feature](fe) Add admin set table status statement by xy720 · Pull Request #23139 · apache/doris

xy720 · 2023-08-17T14:37:15Z

Proposed changes

For some certain bugs, jobs is stuck in FE by the table state. For example, There is a bug which causes table remains ROLLUP state after adding rollup job, then other alter jobs later will not succeed because the table state is always ROLLUP but not NORMAL.

This commit adds a statement which is used to set the state of the specified table.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

xy720 · 2023-08-18T06:04:44Z

run buildall

hello-stephen · 2023-08-18T06:38:38Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.55 seconds
stream load tsv: 537 seconds loaded 74807831229 Bytes, about 132 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162333755 Bytes

xy720 · 2023-08-18T10:28:38Z

run p0

morningman

Please add regression test case.
You can set a table's state to , eg, rollup and set it back to normal

morningman · 2023-08-19T15:14:58Z

+
+ checkProperties();
+ // only support changing table state to normal
+ // if (tableState != OlapTableState.NORMAL) {


Why comment out this?

Useless code. It has been removed

morningman · 2023-08-19T15:22:05Z

+ @SerializedName(value = "table")
+ private String table;
+ @Getter
+ @SerializedName(value = "tabletId")


Suggested change
@SerializedName(value = "tabletId")
@SerializedName(value = "state")

xy720 · 2023-08-22T13:08:24Z

run buildall

xy720 · 2023-08-22T13:08:47Z

regression test has been added, please cc @morningman

xy720 · 2023-08-22T13:12:45Z

run compile

xy720 · 2023-08-23T02:20:29Z

run buildall

xy720 · 2023-08-23T06:26:16Z

run buildall

xy720 · 2023-08-23T09:19:18Z

run buildall

hello-stephen · 2023-08-23T09:54:59Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.95 seconds
stream load tsv: 543 seconds loaded 74807831229 Bytes, about 131 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size: 17161867418 Bytes

morningman

LGTM

github-actions · 2023-08-26T03:00:52Z

PR approved by at least one committer and no changes requested.

github-actions · 2023-08-26T03:00:55Z

PR approved by anyone and no changes requested.

chenlinzhong

LGTM

For some certain bugs, jobs is stuck in FE by the table state. For example, There is a bug which causes table remains ROLLUP state after adding rollup job, then other alter jobs later will not succeed because the table state is always ROLLUP but not NORMAL. This commit adds a statement which is used to set the state of the specified table.

xiaokang · 2023-09-15T00:06:15Z

revert this PR in branch-2.0 since it modify fe metadata OperationType and cause rollback from 2.0.2 to 2.0.1/2.0.0

This reverts commit 412b6ca.

xy720 added 2 commits January 1, 2005 02:07

save code
558e9d9

save
68c240d

morningman reviewed Aug 19, 2023
View reviewed changes

morningman added the dev/2.0.2 label Aug 19, 2023

xy720 force-pushed the admin-set-table-status branch from 2498360 to 68c240dCompare August 23, 2023 06:25

save
a8a5d80

morningman approved these changes Aug 26, 2023
View reviewed changes

github-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Aug 26, 2023

chenlinzhong approved these changes Aug 28, 2023
View reviewed changes

xy720 merged commit eadffed into apache:masterAug 28, 2023

xiaokang added merge_conflict dev/2.0.2-merged and removed dev/2.0.2 labels Aug 30, 2023

xiaokang removed the dev/2.0.2-merged label Sep 15, 2023

xiaokang added a commit that referenced this pull request Sep 15, 2023
Revert "[Feature](fe) Add admin set table status statement (#23139)"
5e8507f
This reverts commit 412b6ca.

mongo360 mentioned this pull request Jun 5, 2024
[doc]delete sql manual docs that mismatched of code in 2.0 apache/doris-website#707
Merged

	@SerializedName(value = "tabletId")
	@SerializedName(value = "state")

Uh oh!

Conversation

xy720 commented Aug 17, 2023

Proposed changes

Further comments

Uh oh!

xy720 commented Aug 18, 2023

Uh oh!

hello-stephen commented Aug 18, 2023

Uh oh!

xy720 commented Aug 18, 2023

Uh oh!

morningman left a comment

Choose a reason for hiding this comment

Uh oh!

morningmanAug 19, 2023

Choose a reason for hiding this comment

Uh oh!

xy720Aug 22, 2023

Choose a reason for hiding this comment

Uh oh!

morningmanAug 19, 2023

Choose a reason for hiding this comment

Uh oh!

xy720Aug 22, 2023

Choose a reason for hiding this comment

Uh oh!

xy720 commented Aug 22, 2023

Uh oh!

xy720 commented Aug 22, 2023

Uh oh!

xy720 commented Aug 22, 2023

Uh oh!

xy720 commented Aug 23, 2023

Uh oh!

xy720 commented Aug 23, 2023

Uh oh!

xy720 commented Aug 23, 2023

Uh oh!

hello-stephen commented Aug 23, 2023

Uh oh!

morningman left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Aug 26, 2023

Uh oh!

github-actionsBot commented Aug 26, 2023

Uh oh!

chenlinzhong left a comment

Choose a reason for hiding this comment

Uh oh!

xiaokang commented Sep 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants