Skip to content

[enhancement](thirdparty) upgrade thirdparty libs - fix compatibility - #23360

Closed
xinyiZzz wants to merge 1 commit into
apache:masterfrom
xinyiZzz:20230816_arrow_flight_be2_push_thridparty2
Closed

[enhancement](thirdparty) upgrade thirdparty libs - fix compatibility#23360
xinyiZzz wants to merge 1 commit into
apache:masterfrom
xinyiZzz:20230816_arrow_flight_be2_push_thridparty2

Conversation

@xinyiZzz

@xinyiZzzxinyiZzz commented Aug 23, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

fix compatibility after #23290

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@xinyiZzzxinyiZzz changed the title [enhancement](thirdparty) upgrade thirdparty libs - fix function reference[enhancement](thirdparty) upgrade thirdparty libs - fix referenceAug 23, 2023
@github-actions

github-actionsBot commented Aug 23, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xinyiZzz
xinyiZzzforce-pushed the 20230816_arrow_flight_be2_push_thridparty2 branch from efd647d to 9ba6eedCompareAugust 23, 2023 10:08
@github-actions

github-actionsBot commented Aug 23, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xinyiZzz

xinyiZzz commented Aug 23, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

1 similar comment
@xinyiZzz

xinyiZzz commented Aug 23, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@xinyiZzz
xinyiZzzforce-pushed the 20230816_arrow_flight_be2_push_thridparty2 branch from 9ba6eed to 674078eCompareAugust 23, 2023 15:20
@xinyiZzz

xinyiZzz commented Aug 23, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Aug 23, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xinyiZzz
xinyiZzzforce-pushed the 20230816_arrow_flight_be2_push_thridparty2 branch from 674078e to a586effCompareAugust 23, 2023 15:37
@xinyiZzz

xinyiZzz commented Aug 23, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Aug 23, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xinyiZzz

xinyiZzz commented Aug 23, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Aug 23, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xinyiZzz

xinyiZzz commented Aug 23, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Aug 23, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Gabriel39
Gabriel39 previously approved these changes Aug 24, 2023
View reviewed changes

@Gabriel39Gabriel39 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 24, 2023
@github-actions

github-actionsBot commented Aug 24, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@xinyiZzz
xinyiZzzforce-pushed the 20230816_arrow_flight_be2_push_thridparty2 branch from efb0818 to bc53862CompareAugust 24, 2023 12:36
@xinyiZzz

xinyiZzz commented Aug 24, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@xinyiZzzxinyiZzz changed the title [enhancement](thirdparty) upgrade thirdparty libs - fix reference[enhancement](thirdparty) upgrade thirdparty libs - fix compatibilityAug 24, 2023
@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Aug 24, 2023
@xinyiZzzxinyiZzz mentioned this pull request Aug 24, 2023
Merged
@github-actions

github-actionsBot commented Aug 24, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen

hello-stephen commented Aug 24, 2023

Copy link
Copy Markdown
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.16 seconds
stream load tsv: 541 seconds loaded 74807831229 Bytes, about 131 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17162033422 Bytes

@xinyiZzz
xinyiZzzforce-pushed the 20230816_arrow_flight_be2_push_thridparty2 branch from bc53862 to cdcf2d8CompareAugust 24, 2023 16:40
@xinyiZzz

xinyiZzz commented Aug 24, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Aug 24, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen

hello-stephen commented Aug 24, 2023

Copy link
Copy Markdown
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45 seconds
stream load tsv: 537 seconds loaded 74807831229 Bytes, about 132 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17161982574 Bytes

@xinyiZzz
xinyiZzzforce-pushed the 20230816_arrow_flight_be2_push_thridparty2 branch from cdcf2d8 to ce36417CompareAugust 26, 2023 09:34
@github-actions

github-actionsBot commented Aug 26, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xinyiZzz

xinyiZzz commented Aug 26, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@xinyiZzz

xinyiZzz commented Aug 26, 2023

Copy link
Copy Markdown
ContributorAuthor

merge to #23414

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gabriel39Gabriel39Gabriel39 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xinyiZzz@hello-stephen@Gabriel39