Skip to content

[fix](metric) fix issue that the counter of rejected transactions does not cover some failed situations for load - #23363

Merged
yiguolei merged 1 commit into
apache:masterfrom
caiconghui:reject_txn
Aug 26, 2023
Merged

[fix](metric) fix issue that the counter of rejected transactions does not cover some failed situations for load#23363
yiguolei merged 1 commit into
apache:masterfrom
caiconghui:reject_txn

Conversation

@caiconghui

@caiconghuicaiconghui commented Aug 23, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

For now，when data exceed database data quota or set invalid timeout, the transaction will be reject without count in metric of rejected transactions，the user may be confused while all transactions metric is ok，but the load task still failed

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@caiconghui

caiconghui commented Aug 23, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@caiconghuicaiconghui added the area/metrics Issues or PRs related to the metrics label Aug 23, 2023
@hello-stephen

hello-stephen commented Aug 23, 2023

Copy link
Copy Markdown
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.67 seconds
stream load tsv: 554 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.5 seconds inserted 10000000 Rows, about 338K ops/s
storage size: 17162064555 Bytes

@caiconghui

caiconghui commented Aug 23, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

weizuo93
weizuo93 approved these changes Aug 23, 2023
View reviewed changes

@weizuo93weizuo93 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 23, 2023
@github-actions

github-actionsBot commented Aug 23, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Aug 23, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yiguolei

yiguolei commented Aug 24, 2023

Copy link
Copy Markdown
Contributor

run buildall

@caiconghui

caiconghui commented Aug 24, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

hello-stephen commented Aug 24, 2023

Copy link
Copy Markdown
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.06 seconds
stream load tsv: 544 seconds loaded 74807831229 Bytes, about 131 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17162093822 Bytes

@morningman

morningman commented Aug 25, 2023

Copy link
Copy Markdown
Contributor

Could you explain more in detail?

@caiconghui

caiconghui commented Aug 25, 2023

Copy link
Copy Markdown
ContributorAuthor

Could you explain more in detail?

done

yiguolei
yiguolei approved these changes Aug 26, 2023
View reviewed changes

@yiguoleiyiguolei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei
yiguolei merged commit 9391825 into apache:masterAug 26, 2023
tudouzhao pushed a commit to tudouzhao/doris that referenced this pull request Aug 26, 2023
@caiconghuitudouzhao
[fix](metric) fix issue that the counter of rejected transactions doe…
1d1f866
…s not cover some failed situations for load (apache#23363)
Co-authored-by: caiconghui1 <caiconghui1@jd.com>
[enhancement](thirdparty) upgrade thirdparty libs - again (apache#23414)
submit again apache#23290 (not upgrade brpc, because bthread local has error)
protobuf 3.15.0 -> 21.11
glog 0.4.0 -> 0.6.0
lz4 1.9.3 -> 1.9.4
curl 7.79.0 -> 8.2.1
zstd 1.5.2 -> 1.5.5
arrow 7.0.0 -> 13.0.0
abseil 20220623.1 -> 2023012.3
orc 1.7.2 -> 1.9.0
jemalloc for arrow 5.2.1 -> 5.3.0
xsimd 7.0.0 -> 13.0.0
opentelemetry-proto 0.19.0 -> 1.0.0
opentelemetry 1.8.3 -> 1.10.0
new:
c-ares -> 1.19.1
grpc -> 1.54.3
morningman pushed a commit that referenced this pull request Aug 28, 2023
@caiconghuicaiconghui1@morningman
[fix](metric) fix issue that the counter of rejected transactions doe…
6ee5488
…s not cover some failed situations for load (#23363)
Co-authored-by: caiconghui1 <caiconghui1@jd.com>
xiaokang pushed a commit that referenced this pull request Aug 30, 2023
@caiconghuicaiconghui1@xiaokang
[fix](metric) fix issue that the counter of rejected transactions doe…
f622305
…s not cover some failed situations for load (#23363)
Co-authored-by: caiconghui1 <caiconghui1@jd.com>
GoGoWen pushed a commit to GoGoWen/incubator-doris that referenced this pull request Sep 7, 2023
@caiconghuicaiconghui1
[fix](metric) fix issue that the counter of rejected transactions doe…
bba1d83
…s not cover some failed situations for load (apache#23363)
Co-authored-by: caiconghui1 <caiconghui1@jd.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguoleiyiguoleiyiguolei approved these changes
@weizuo93weizuo93weizuo93 approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.area/metricsIssues or PRs related to the metricsdev/1.2.7-mergeddev/2.0.2-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@caiconghui@hello-stephen@yiguolei@morningman@weizuo93@xiaokang