Uh oh!
There was an error while loading. Please reload this page.
[Fix](cache) fix query cache returns wrong result after deleting partitions. - #23555
Conversation
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
clang-tidy review says "All clean, LGTM! 👍" |
dutyu
commented
Aug 28, 2023
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
hello-stephen
commented
Aug 28, 2023
(From new machine)TeamCity pipeline, clickbench performance test result: |
hello-stephen
commented
Aug 28, 2023
(From new machine)TeamCity pipeline, clickbench performance test result: |
clang-tidy review says "All clean, LGTM! 👍" |
dutyu
commented
Aug 28, 2023
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
hello-stephen
commented
Aug 28, 2023
(From new machine)TeamCity pipeline, clickbench performance test result: |
dutyu
commented
Aug 29, 2023
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
hello-stephen
commented
Aug 29, 2023
(From new machine)TeamCity pipeline, clickbench performance test result: |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
dutyu
commented
Aug 30, 2023
run buildall |
PR approved by at least one committer and no changes requested. |
clang-tidy review says "All clean, LGTM! 👍" |
hello-stephen
commented
Aug 30, 2023
(From new machine)TeamCity pipeline, clickbench performance test result: |
…itions. (#23555) The reason is that sql cache just use partitionKey , latestVersion and latestTime to check if the cache should be returned, if we delete some partition(s) which is not the latest updated partition, all above values are not changed, so the cache will hit. Use a field to save the partition num of these tables and sum the partition nums and send it to BE, there are two situations which contains delete-partition ops: - just delete some partition(s), so the sum of partition num will be lower than before. - delete some partition(s) coexists with add some partition(s), so the latest time or latest version will be higher than before.
Proposed changes
Issue Number: close#23548
The reason is that sql cache just use
partitionKey,latestVersionandlatestTimeto check if the cache should be returned, if we delete some partition(s) which is not the latest updated partition, all above values are not changed, so the cache will hit.Use a field to save the partition num of these tables and sum the partition nums and send it to
BE, there are two situations which contains delete-partition ops:Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...