Uh oh!
There was an error while loading. Please reload this page.
[improve](Status) Add new status codeKEY_NOT_FOUND and KEY_ALREADY_EXISTS for merge on write - #23619
Conversation
89fc98a to
024e354Comparebobhan1
commented
Aug 29, 2023
run buildall |
Uh oh!
There was an error while loading. Please reload this page.
PR approved by anyone and no changes requested. |
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
clang-tidy review says "All clean, LGTM! 👍" |
hello-stephen
commented
Aug 29, 2023
(From new machine)TeamCity pipeline, clickbench performance test result: |
bobhan1
commented
Aug 29, 2023
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
hello-stephen
commented
Aug 29, 2023
(From new machine)TeamCity pipeline, clickbench performance test result: |
…_EXISTS` for merge on write (#23619)
Proposed changes
For merge on write table, when loading data, it will call
lookup_row_keyto find if there exists a row with the same key as the inserted row. The return value oflookup_row_keycan be one ofStatus::NotFound/Status::AlreadyExist/Status::OK. Currently, call toStatus::NotFound/Status::AlreadyExistwill lead to printing stacktrace info. However, the number of call toStatus::NotFound/Status::AlreadyExistcan be up to the number of rows inserted times the number segments of the tablet in the worst case. So it may print lots of useless stacktrace info when loading data. So this PR add two new status code for this scenarios to eliminate printing these useless stacktrace info.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...