Skip to content

[fix] (mac compile) Fix mac compile error & fe start time related - #23727

Merged
yiguolei merged 4 commits into
apache:masterfrom
RoanHeNaN:new-cancel
Sep 1, 2023
Merged

[fix] (mac compile) Fix mac compile error & fe start time related#23727
yiguolei merged 4 commits into
apache:masterfrom
RoanHeNaN:new-cancel

Conversation

@RoanHeNaN

@RoanHeNaNRoanHeNaN commented Aug 31, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Fix of PR #23582

  1. Some Fe codes are deleted by [Improvement](pipeline) Cancel outdated query if original fe restarts #23582 , need to be added back;
  2. Fix mac build failed caused by wrong thrift declaration order.

@github-actions

github-actionsBot commented Aug 31, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@RoanHeNaNRoanHeNaN changed the title [fix] (pipeline) Fix mac compile error. [fix] (mac compile) Fix mac compile error & fe start time relatedAug 31, 2023
@RoanHeNaN

RoanHeNaN commented Aug 31, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Aug 31, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

BiteTheDDDDt
BiteTheDDDDt previously approved these changes Aug 31, 2023
View reviewed changes
@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 31, 2023
@github-actions

github-actionsBot commented Aug 31, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Aug 31, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Aug 31, 2023
@RoanHeNaN

RoanHeNaN commented Aug 31, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Aug 31, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen

hello-stephen commented Aug 31, 2023

Copy link
Copy Markdown
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.89 seconds
stream load tsv: 550 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17161940622 Bytes

yiguolei
yiguolei approved these changes Aug 31, 2023
View reviewed changes

@yiguoleiyiguolei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 31, 2023
@github-actions

github-actionsBot commented Aug 31, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

hf200012
hf200012 approved these changes Aug 31, 2023
View reviewed changes

@hf200012hf200012 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei
yiguolei merged commit 16d6357 into apache:masterSep 1, 2023
@RoanHeNaN
RoanHeNaN deleted the new-cancel branch September 5, 2023 07:02
RoanHeNaN added a commit to RoanHeNaN/doris that referenced this pull request Sep 6, 2023
@RoanHeNaN
[fix] (mac compile) Fix mac compile error & fe start time related (ap…
9aaacc8
…ache#23727)
Fix of PR apache#23582
Some Fe codes are deleted by [Improvement](pipeline) Cancel outdated query if original fe restarts apache#23582 , need to be added back;
Fix mac build failed caused by wrong thrift declaration order.
@xiaokang

xiaokang commented Oct 31, 2023

Copy link
Copy Markdown
Contributor

not merge this fix in 2.0

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hf200012hf200012hf200012 approved these changes
@yiguoleiyiguoleiyiguolei approved these changes
@BiteTheDDDDtBiteTheDDDDtBiteTheDDDDt left review comments

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.merge_conflictreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@RoanHeNaN@hello-stephen@xiaokang@hf200012@BiteTheDDDDt@yiguolei