Uh oh!
There was an error while loading. Please reload this page.
[FIX](array/map)fix array map batch append data with right next_array_item_rowid - #23779
Conversation
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
clang-tidy review says "All clean, LGTM! 👍" |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
xiaokang
commented
Sep 2, 2023
run buildall |
hello-stephen
commented
Sep 2, 2023
(From new machine)TeamCity pipeline, clickbench performance test result: |
clang-tidy review says "All clean, LGTM! 👍" |
amorynan
commented
Sep 4, 2023
run buildall |
hello-stephen
commented
Sep 4, 2023
(From new machine)TeamCity pipeline, clickbench performance test result: |
amorynan
commented
Sep 4, 2023
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
hello-stephen
commented
Sep 4, 2023
(From new machine)TeamCity pipeline, clickbench performance test result: |
clang-tidy review says "All clean, LGTM! 👍" |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
amorynan
commented
Sep 4, 2023
run buildall |
xiaokang
commented
Sep 4, 2023
run buildall |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
clang-tidy review says "All clean, LGTM! 👍" |
doris-robot
commented
Sep 4, 2023
(From new machine)TeamCity pipeline, clickbench performance test result: |
clang-tidy review says "All clean, LGTM! 👍" |
amorynan
commented
Sep 5, 2023
run buildall |
doris-robot
commented
Sep 5, 2023
(From new machine)TeamCity pipeline, clickbench performance test result: |
Uh oh!
There was an error while loading. Please reload this page.
amorynan
commented
Sep 5, 2023
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
doris-robot
commented
Sep 5, 2023
(From new machine)TeamCity pipeline, clickbench performance test result: |
PR approved by at least one committer and no changes requested. |
Proposed changes
Issue Number: close #xxx
when we batch append data , array map's offset column data finish_current_page will set next_array_item_ordinal which help when reading page data to calculate last offset
before we append page one by one which implict make sure the last offset is always right when read from item_writer->next_rowset_id()
now we append page batch , so item_writer next_rowset_id may not make sure the next_rowset_id is exactly last offset value , but we know this continues data in offset column data, we can put the right data in callback function
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...