[Fix](BinaryPrefixPage) stop to read values when current pos reached the end of the page in `BinaryPrefixPageDecoder::next_batch` by bobhan1 · Pull Request #23855 · apache/doris

bobhan1 · 2023-09-04T08:58:22Z

Proposed changes

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

bobhan1 · 2023-09-04T08:58:39Z

run buildall

github-actions · 2023-09-04T09:07:11Z

clang-tidy review says "All clean, LGTM! 👍"

hello-stephen · 2023-09-04T09:30:20Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.34 seconds
stream load tsv: 531 seconds loaded 74807831229 Bytes, about 134 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17161893700 Bytes

github-actions · 2023-09-05T06:35:54Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2023-09-05T06:37:19Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2023-09-05T06:37:35Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2023-09-05T06:38:55Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2023-09-05T06:51:24Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2023-09-05T06:51:28Z

clang-tidy review says "All clean, LGTM! 👍"

zhannngchen

LGTM

github-actions · 2023-09-05T07:06:51Z

PR approved by at least one committer and no changes requested.

github-actions · 2023-09-05T07:06:54Z

PR approved by anyone and no changes requested.

github-actions · 2023-09-05T07:11:32Z

clang-tidy review says "All clean, LGTM! 👍"

bobhan1 · 2023-09-05T09:09:02Z

run buildall

doris-robot · 2023-09-05T09:39:02Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.08 seconds
stream load tsv: 528 seconds loaded 74807831229 Bytes, about 135 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162052827 Bytes

bobhan1 · 2023-09-06T01:31:28Z

run buildall

github-actions · 2023-09-06T02:30:12Z

PR approved by at least one committer and no changes requested.

bobhan1 · 2023-09-06T03:17:00Z

run buildall

github-actions · 2023-09-06T03:20:28Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2023-09-06T03:21:38Z

clang-tidy review says "All clean, LGTM! 👍"

zhannngchen

LGTM

github-actions · 2023-09-06T03:36:03Z

PR approved by at least one committer and no changes requested.

doris-robot · 2023-09-06T03:54:47Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.24 seconds
stream load tsv: 530 seconds loaded 74807831229 Bytes, about 134 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162093084 Bytes

github-actions · 2023-09-06T04:05:19Z

clang-tidy review says "All clean, LGTM! 👍"

bobhan1 · 2023-09-06T04:09:51Z

run buildall

doris-robot · 2023-09-06T04:47:52Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.86 seconds
stream load tsv: 531 seconds loaded 74807831229 Bytes, about 134 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17161985243 Bytes

github-actions · 2023-09-06T06:42:05Z

PR approved by at least one committer and no changes requested.

yiguolei

LGTM

…the end of the page in `BinaryPrefixPageDecoder::next_batch` (#23855)

yiguolei reviewed Sep 5, 2023
View reviewed changes

Comment threadbe/src/olap/rowset/segment_v2/binary_prefix_page.cpp Outdated

bobhan1 force-pushed the fix-BinaryPrefixPage branch 4 times, most recently from 118acbd to 6867914Compare September 5, 2023 06:31

zhannngchen reviewed Sep 5, 2023
View reviewed changes

Comment threadbe/src/olap/rowset/segment_v2/binary_prefix_page.cpp Outdated

bobhan1 force-pushed the fix-BinaryPrefixPage branch from 6867914 to 885eef8Compare September 5, 2023 06:44

zhannngchen previously approved these changes Sep 5, 2023
View reviewed changes

zhannngchen requested a review from yiguolei September 5, 2023 07:06

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 5, 2023

github-actionsBot added the reviewed label Sep 5, 2023

zhannngchen added the dev/2.0.2 label Sep 5, 2023

bobhan1 dismissed zhannngchen’s stale review via da53196September 6, 2023 01:30

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Sep 6, 2023

bobhan1 requested a review from zhannngchen September 6, 2023 01:31

yiguolei reviewed Sep 6, 2023
View reviewed changes

Comment threadbe/src/olap/rowset/segment_v2/binary_prefix_page.cpp Outdated

bobhan1 dismissed zhannngchen’s stale review via 2c3661eSeptember 6, 2023 03:12

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Sep 6, 2023

update
8a3d1d8

bobhan1 force-pushed the fix-BinaryPrefixPage branch from 2c3661e to 8a3d1d8Compare September 6, 2023 03:13

zhannngchen previously approved these changes Sep 6, 2023
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 6, 2023

fix beut
a4fc60e

bobhan1 dismissed zhannngchen’s stale review via a4fc60eSeptember 6, 2023 03:57

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Sep 6, 2023

bobhan1 requested review from yiguolei and zhannngchen September 6, 2023 04:10

zhannngchen approved these changes Sep 6, 2023
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 6, 2023

yiguolei approved these changes Sep 6, 2023
View reviewed changes

zhannngchen merged commit 95ae537 into apache:masterSep 6, 2023

xiaokang added dev/2.0.2-merged and removed dev/2.0.2 labels Sep 7, 2023

xiaokang pushed a commit that referenced this pull request Sep 7, 2023
[Fix](BinaryPrefixPage) stop to read values when current pos reached …
2fa15cc
…the end of the page in `BinaryPrefixPageDecoder::next_batch` (#23855)

bobhan1 mentioned this pull request Sep 11, 2023
[Fix](status)Fix leaky abstraction and shield the status code END_OF_FILE from upper layers #24165
Merged

Uh oh!

Conversation

bobhan1 commented Sep 4, 2023

Proposed changes

Further comments

Uh oh!

bobhan1 commented Sep 4, 2023

Uh oh!

github-actionsBot commented Sep 4, 2023

Uh oh!

hello-stephen commented Sep 4, 2023

Uh oh!

Uh oh!

github-actionsBot commented Sep 5, 2023

Uh oh!

github-actionsBot commented Sep 5, 2023

Uh oh!

github-actionsBot commented Sep 5, 2023

Uh oh!

github-actionsBot commented Sep 5, 2023

Uh oh!

Uh oh!

github-actionsBot commented Sep 5, 2023

Uh oh!

github-actionsBot commented Sep 5, 2023

Uh oh!

zhannngchen left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Sep 5, 2023

Uh oh!

github-actionsBot commented Sep 5, 2023

Uh oh!

github-actionsBot commented Sep 5, 2023

Uh oh!

bobhan1 commented Sep 5, 2023

Uh oh!

doris-robot commented Sep 5, 2023

Uh oh!

bobhan1 commented Sep 6, 2023

Uh oh!

github-actionsBot commented Sep 6, 2023

Uh oh!

Uh oh!

bobhan1 commented Sep 6, 2023

Uh oh!

github-actionsBot commented Sep 6, 2023

Uh oh!

github-actionsBot commented Sep 6, 2023

Uh oh!

zhannngchen left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Sep 6, 2023

Uh oh!

doris-robot commented Sep 6, 2023

Uh oh!

github-actionsBot commented Sep 6, 2023

Uh oh!

bobhan1 commented Sep 6, 2023

Uh oh!

doris-robot commented Sep 6, 2023

Uh oh!

github-actionsBot commented Sep 6, 2023

Uh oh!

yiguolei left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants