[BUG](view) fix can't create view with lambda function by zhangstar333 · Pull Request #23942 · apache/doris

zhangstar333 · 2023-09-05T15:27:17Z

Proposed changes

before the lambda function Expr not implement toSqlImpl() function.
so it's call parent function, which is not suit for lambda function.
and will be have error when create view.

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

zhangstar333 · 2023-09-05T15:27:27Z

run buildall

doris-robot · 2023-09-05T16:05:39Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.21 seconds
stream load tsv: 547 seconds loaded 74807831229 Bytes, about 130 MB/s
stream load json: 22 seconds loaded 2358488459 Bytes, about 102 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162415617 Bytes

CalvinKirs · 2023-09-06T02:22:56Z

run buildall

HappenLee · 2023-09-06T02:56:37Z

+ sb.append("(");
+ int childSize = children.size();
+ Expr lastExpr = getChild(childSize - 1);
+ boolean lastIsLambdaExpr = (lastExpr instanceof LambdaFunctionExpr);


add comment for the code, trickly here

HappenLee · 2023-09-06T02:58:50Z

+ // array_filter(array, boolean) only implement as lambda function
+ // eg: SELECT array_filter(`array_d`, array_map(x -> (x >= 1), `array_d`))
+ // can't as a normal function for BE, need handle by lambda function call expr
+ if (fnName.getFunction().equalsIgnoreCase("array_filter")) {


better BE support function "array_filter" as function call

doris-robot · 2023-09-06T02:59:52Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.7 seconds
stream load tsv: 533 seconds loaded 74807831229 Bytes, about 133 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162068281 Bytes

zhangstar333 · 2023-09-07T05:58:07Z

run buildall

github-actions · 2023-09-07T06:01:29Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2023-09-07T06:23:46Z

TeamCity be ut coverage result:
Function Coverage: 37.00% (7895/21340)
Line Coverage: 28.94% (63263/218585)
Region Coverage: 27.89% (32899/117954)
Branch Coverage: 24.46% (16893/69072)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c67cd238088ba4b39fb521e4a4f9e5699c2adf49_c67cd238088ba4b39fb521e4a4f9e5699c2adf49/report/index.html

doris-robot · 2023-09-07T06:35:17Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.28 seconds
stream load tsv: 540 seconds loaded 74807831229 Bytes, about 132 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162094047 Bytes

zhangstar333 · 2023-09-08T02:16:47Z

run buildall

github-actions · 2023-09-08T02:23:56Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2023-09-08T02:36:46Z

TeamCity be ut coverage result:
Function Coverage: 36.99% (7891/21332)
Line Coverage: 29.01% (63351/218366)
Region Coverage: 27.93% (32892/117785)
Branch Coverage: 24.51% (16896/68948)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ccd215a75ae3c59dfd07501090550a9073e0668a_ccd215a75ae3c59dfd07501090550a9073e0668a/report/index.html

doris-robot · 2023-09-08T02:58:23Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.31 seconds
stream load tsv: 534 seconds loaded 74807831229 Bytes, about 133 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17162175634 Bytes

HappenLee

LGTM

github-actions · 2023-09-08T03:04:35Z

PR approved by at least one committer and no changes requested.

github-actions · 2023-09-08T03:04:38Z

PR approved by anyone and no changes requested.

zhangstar333 · 2023-09-08T10:24:13Z

run buildall

github-actions · 2023-09-08T10:30:25Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2023-09-08T10:47:07Z

TeamCity be ut coverage result:
Function Coverage: 36.92% (7899/21394)
Line Coverage: 28.93% (63382/219096)
Region Coverage: 27.87% (32909/118060)
Branch Coverage: 24.46% (16899/69098)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d2541dd92b0bb51360115febbdfd0ea267e14500_d2541dd92b0bb51360115febbdfd0ea267e14500/report/index.html

doris-robot · 2023-09-08T11:03:03Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.21 seconds
stream load tsv: 527 seconds loaded 74807831229 Bytes, about 135 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size: 17162257297 Bytes

zhangstar333 · 2023-09-08T13:11:03Z

run buildall

doris-robot · 2023-09-08T13:35:53Z

TeamCity be ut coverage result:
Function Coverage: 36.93% (7899/21392)
Line Coverage: 28.93% (63387/219084)
Region Coverage: 27.88% (32911/118042)
Branch Coverage: 24.47% (16904/69092)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d2541dd92b0bb51360115febbdfd0ea267e14500_d2541dd92b0bb51360115febbdfd0ea267e14500/report/index.html

doris-robot · 2023-09-08T13:50:17Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.98 seconds
stream load tsv: 536 seconds loaded 74807831229 Bytes, about 133 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17162038159 Bytes

yiguolei

LGTM

github-actions · 2023-09-10T03:27:51Z

PR approved by at least one committer and no changes requested.

Gabriel39

LGTM

before the lambda function Expr not implement toSqlImpl() function. so it's call parent function, which is not suit for lambda function. and will be have error when create view.

HappenLee reviewed Sep 6, 2023
View reviewed changes

[BUG](view) fix can't create view with lambda function
3617195

CalvinKirs added a commit to CalvinKirs/incubator-doris that referenced this pull request Sep 7, 2023
pickapache#23942
808c7fa

add array_filter function
c67cd23

zhangstar333 force-pushed the fix_compile branch from dbd2758 to c67cd23Compare September 7, 2023 05:54

update docs
ccd215a

HappenLee previously approved these changes Sep 8, 2023
View reviewed changes

HappenLee added the dev/2.0.2 label Sep 8, 2023

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 8, 2023

github-actionsBot added the reviewed label Sep 8, 2023

update docs
d2541dd

zhangstar333 dismissed HappenLee’s stale review via d2541ddSeptember 8, 2023 10:24

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Sep 8, 2023

yiguolei approved these changes Sep 10, 2023
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 10, 2023

Gabriel39 approved these changes Sep 11, 2023
View reviewed changes

yiguolei merged commit cd13f9e into apache:masterSep 11, 2023

xiaokang added dev/2.0.2-merged and removed dev/2.0.2 labels Sep 11, 2023

Uh oh!

Conversation

zhangstar333 commented Sep 5, 2023

Proposed changes

Further comments

Uh oh!

zhangstar333 commented Sep 5, 2023

Uh oh!

doris-robot commented Sep 5, 2023

Uh oh!

CalvinKirs commented Sep 6, 2023

Uh oh!

HappenLeeSep 6, 2023

Choose a reason for hiding this comment

Uh oh!

HappenLeeSep 6, 2023

Choose a reason for hiding this comment

Uh oh!

doris-robot commented Sep 6, 2023

Uh oh!

zhangstar333 commented Sep 7, 2023

Uh oh!

github-actionsBot commented Sep 7, 2023

Uh oh!

doris-robot commented Sep 7, 2023

Uh oh!

doris-robot commented Sep 7, 2023

Uh oh!

zhangstar333 commented Sep 8, 2023

Uh oh!

github-actionsBot commented Sep 8, 2023

Uh oh!

doris-robot commented Sep 8, 2023

Uh oh!

doris-robot commented Sep 8, 2023

Uh oh!

HappenLee left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Sep 8, 2023

Uh oh!

github-actionsBot commented Sep 8, 2023

Uh oh!

zhangstar333 commented Sep 8, 2023

Uh oh!

github-actionsBot commented Sep 8, 2023

Uh oh!

doris-robot commented Sep 8, 2023

Uh oh!

doris-robot commented Sep 8, 2023

Uh oh!

zhangstar333 commented Sep 8, 2023

Uh oh!

doris-robot commented Sep 8, 2023

Uh oh!

doris-robot commented Sep 8, 2023

Uh oh!

yiguolei left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Sep 10, 2023

Uh oh!

Gabriel39 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants