Skip to content

[chore](thirdparty)We need to issue an error when starting FE without setting the Java home environment#23943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 5 commits into from
Sep 21, 2023
Merged

[chore](thirdparty)We need to issue an error when starting FE without setting the Java home environment #23943

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1baf0fd
Change JAVA_HOME The Logic
xyfsjq Sep 5, 2023
0b2259d
Change JAVA_HOME The Logicdd
xyfsjq Sep 5, 2023
d9119c4
Change JAVA_HOME The Logicdd
xyfsjq Sep 6, 2023
44d87f3
Change JAVA_HOME The Logice
xyfsjq Sep 18, 2023
5888bdf
Merge branch 'master' into dev_yifan
yiguolei Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion bin/start_fe.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -119,8 +119,14 @@ if [[ -e "${DORIS_HOME}/bin/palo_env.sh" ]]; then
source "${DORIS_HOME}/bin/palo_env.sh"
fi

#Due to the machine not being configured with Java home, in this case, when FE cannot start, it is necessary to prompt an error message indicating that it has not yet been configured with Java home.

if [[ -z "${JAVA_HOME}" ]]; then
JAVA="$(command -v java)"
if ! command -v java &>/dev/null; then

@yiguoleiyiguoleiSep 6, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add some comment here， why do we need write code like this.
Or the other developer may refactor code and rewrite this code.

@xyfsjqxyfsjqSep 6, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the customer's machine not being configured with Java home, starting FE will result in startup failure, no error prompts, and logs. In this case, when the FE cannot start, it is necessary to prompt an error message indicating that it has not yet configured Java home.

@adonis0147adonis0147Sep 6, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @xyfsjq , would you show the errors here if we don't set JAVA_HOME before starting FE?

By the way, if it was caused by the environment variable JAVA_HOME which is unset, we should check the variable JAVA_HOME straightforwardly.

JAVA=""
else
JAVA="$(command -v java)"
fi
else
JAVA="${JAVA_HOME}/bin/java"
fi
Expand Down