Skip to content

(imporve)Improve error message - #23968

Merged
zy-kkk merged 3 commits into
apache:masterfrom
LemonLiTree:fix-error-info
Sep 11, 2023
Merged

(imporve)Improve error message#23968
zy-kkk merged 3 commits into
apache:masterfrom
LemonLiTree:fix-error-info

Conversation

@LemonLiTree

@LemonLiTreeLemonLiTree commented Sep 6, 2023

Copy link
Copy Markdown
Contributor

before:
image
now:
image

@LemonLiTree

LemonLiTree commented Sep 6, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

zy-kkk
zy-kkk previously approved these changes Sep 6, 2023
View reviewed changes

@zy-kkkzy-kkk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 6, 2023
@github-actions

github-actionsBot commented Sep 6, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Sep 6, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Sep 6, 2023
@LemonLiTree

LemonLiTree commented Sep 7, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Sep 7, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.68 seconds
stream load tsv: 541 seconds loaded 74807831229 Bytes, about 131 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162159826 Bytes

@LemonLiTree

LemonLiTree commented Sep 8, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Sep 8, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.2 seconds
stream load tsv: 530 seconds loaded 74807831229 Bytes, about 134 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size: 17162318683 Bytes

JNSimba
JNSimba approved these changes Sep 8, 2023
View reviewed changes

@JNSimbaJNSimba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 11, 2023
@github-actions

github-actionsBot commented Sep 11, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@zy-kkk
zy-kkk merged commit 480fcef into apache:masterSep 11, 2023
xiaokang pushed a commit that referenced this pull request Sep 11, 2023
@LemonLiTree@xiaokang
[typo](errmsg) Improve partition error message (#23968)
051049d
xiaokang pushed a commit that referenced this pull request Sep 13, 2023
@LemonLiTree@xiaokang
[typo](errmsg) Improve partition error message (#23968)
a19a53b
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JNSimbaJNSimbaJNSimba approved these changes
@zy-kkkzy-kkkzy-kkk approved these changes
+1 more reviewer
@DongLiang-0DongLiang-0DongLiang-0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.2-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@LemonLiTree@doris-robot@JNSimba@DongLiang-0@zy-kkk@xiaokang