Skip to content

[bug](join) fix outer join not add tuple is null column when build rows is 0 - #23974

Merged
BiteTheDDDDt merged 1 commit into
apache:masterfrom
zhangstar333:join_tuple_is_null
Sep 8, 2023
Merged

[bug](join) fix outer join not add tuple is null column when build rows is 0#23974
BiteTheDDDDt merged 1 commit into
apache:masterfrom
zhangstar333:join_tuple_is_null

Conversation

@zhangstar333

Copy link
Copy Markdown
Contributor

in this PR #23713
add some opt when build rows is 0 and join type is left outer join.
but not add tuple is null column in block, which will cause coredump if need those column.

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@zhangstar333

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.6 seconds
stream load tsv: 537 seconds loaded 74807831229 Bytes, about 132 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162244477 Bytes

@zhangstar333

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.99% (7891/21334)
Line Coverage: 28.94% (63236/218522)
Region Coverage: 27.89% (32893/117934)
Branch Coverage: 24.45% (16888/69064)
Coverage Report: http://coverage.selectdb-in.cc/coverage/69374a55ee7d31fa928d1dedd27215160a775198_69374a55ee7d31fa928d1dedd27215160a775198/report/index.html

@doris-robot

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.28 seconds
stream load tsv: 545 seconds loaded 74807831229 Bytes, about 130 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162196527 Bytes

@zhangstar333

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.01% (7889/21318)
Line Coverage: 29.02% (63340/218246)
Region Coverage: 27.92% (32879/117742)
Branch Coverage: 24.51% (16894/68930)
Coverage Report: http://coverage.selectdb-in.cc/coverage/69374a55ee7d31fa928d1dedd27215160a775198_69374a55ee7d31fa928d1dedd27215160a775198/report/index.html

@doris-robot

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.54 seconds
stream load tsv: 530 seconds loaded 74807831229 Bytes, about 134 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162052413 Bytes

@wm1581066wm1581066 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@BiteTheDDDDt
BiteTheDDDDt merged commit 76ca57c into apache:masterSep 8, 2023
zhangstar333 added a commit to zhangstar333/incubator-doris that referenced this pull request Sep 8, 2023
…ws is 0 (apache#23974)
fix outer join not add tuple is null column when build rows is 0
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@zhangstar333@doris-robot@BiteTheDDDDt@wm1581066@xiaokang@yiguolei