[feature](datetime-func)support milliseconds_add/sub/diff and microseconds_diff by LemonLiTree · Pull Request #24114 · apache/doris

LemonLiTree · 2023-09-08T10:02:31Z

Proposed changes

Issue Number: close#23939

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

github-actions · 2023-09-08T10:09:01Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2023-09-08T10:20:07Z

clang-tidy review says "All clean, LGTM! 👍"

LemonLiTree · 2023-09-08T10:21:46Z

run buildall

doris-robot · 2023-09-08T11:22:28Z

TeamCity be ut coverage result:
Function Coverage: 36.91% (7895/21387)
Line Coverage: 28.93% (63363/219047)
Region Coverage: 27.87% (32908/118057)
Branch Coverage: 24.46% (16898/69094)
Coverage Report: http://coverage.selectdb-in.cc/coverage/51f5998f6ee4f9ed6708b43731d24f9096552d9e_51f5998f6ee4f9ed6708b43731d24f9096552d9e/report/index.html

doris-robot · 2023-09-08T11:46:30Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.75 seconds
stream load tsv: 534 seconds loaded 74807831229 Bytes, about 133 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17161963914 Bytes

Gabriel39

LGTM

LemonLiTree · 2023-09-17T11:46:15Z

run buildall

github-actions · 2023-09-17T11:53:17Z

clang-tidy review says "All clean, LGTM! 👍"

Gabriel39

LGTM

github-actions · 2023-09-17T12:00:58Z

PR approved by at least one committer and no changes requested.

github-actions · 2023-09-17T12:01:01Z

PR approved by anyone and no changes requested.

doris-robot · 2023-09-17T12:52:00Z

TeamCity be ut coverage result:
Function Coverage: 36.83% (7981/21667)
Line Coverage: 28.86% (64043/221931)
Region Coverage: 27.75% (33238/119787)
Branch Coverage: 24.37% (17037/69910)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b29f9c51d49cc159615257df709f5a85e9c05245_b29f9c51d49cc159615257df709f5a85e9c05245/report/index.html

doris-robot · 2023-09-17T13:14:09Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.81 seconds
stream load tsv: 598 seconds loaded 74807831229 Bytes, about 119 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162467742 Bytes

LemonLiTree · 2023-09-18T02:14:25Z

run p0

LemonLiTree · 2023-09-18T09:26:43Z

run buildall

doris-robot · 2023-09-18T10:26:06Z

TeamCity be ut coverage result:
Function Coverage: 36.83% (7981/21669)
Line Coverage: 28.86% (64060/221951)
Region Coverage: 27.75% (33249/119798)
Branch Coverage: 24.38% (17044/69916)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b29f9c51d49cc159615257df709f5a85e9c05245_b29f9c51d49cc159615257df709f5a85e9c05245/report/index.html

doris-robot · 2023-09-18T10:37:35Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.24 seconds
stream load tsv: 601 seconds loaded 74807831229 Bytes, about 118 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162529927 Bytes

LemonLiTree · 2023-09-19T04:04:40Z

run buildall

github-actions · 2023-09-19T04:12:27Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2023-09-19T04:47:43Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.69 seconds
stream load tsv: 607 seconds loaded 74807831229 Bytes, about 117 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162399492 Bytes

doris-robot · 2023-09-19T05:02:09Z

TeamCity be ut coverage result:
Function Coverage: 36.83% (7979/21667)
Line Coverage: 28.85% (64035/221960)
Region Coverage: 27.75% (33240/119796)
Branch Coverage: 24.36% (17034/69916)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ea89eba906bcfec4f99b033d0e79e44e693672de_ea89eba906bcfec4f99b033d0e79e44e693672de/report/index.html

LemonLiTree · 2023-09-19T09:15:54Z

run buildall

doris-robot · 2023-09-19T09:32:29Z

TeamCity be ut coverage result:
Function Coverage: 36.83% (7981/21667)
Line Coverage: 28.86% (64066/221960)
Region Coverage: 27.76% (33259/119796)
Branch Coverage: 24.38% (17043/69916)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ea89eba906bcfec4f99b033d0e79e44e693672de_ea89eba906bcfec4f99b033d0e79e44e693672de/report/index.html

doris-robot · 2023-09-19T09:46:20Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.26 seconds
stream load tsv: 600 seconds loaded 74807831229 Bytes, about 118 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162255708 Bytes

LemonLiTree · 2023-09-19T10:44:06Z

run buildall

doris-robot · 2023-09-19T11:12:17Z

TeamCity be ut coverage result:
Function Coverage: 36.76% (7981/21713)
Line Coverage: 28.83% (64060/222212)
Region Coverage: 27.73% (33262/119955)
Branch Coverage: 24.35% (17045/69998)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ea89eba906bcfec4f99b033d0e79e44e693672de_ea89eba906bcfec4f99b033d0e79e44e693672de/report/index.html

doris-robot · 2023-09-19T11:29:40Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.18 seconds
stream load tsv: 598 seconds loaded 74807831229 Bytes, about 119 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162150312 Bytes

LemonLiTree · 2023-09-19T13:06:03Z

run buildall

doris-robot · 2023-09-19T13:24:11Z

TeamCity be ut coverage result:
Function Coverage: 36.75% (7979/21713)
Line Coverage: 28.82% (64051/222214)
Region Coverage: 27.73% (33259/119956)
Branch Coverage: 24.34% (17040/69998)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ea89eba906bcfec4f99b033d0e79e44e693672de_ea89eba906bcfec4f99b033d0e79e44e693672de/report/index.html

doris-robot · 2023-09-19T13:38:06Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.61 seconds
stream load tsv: 597 seconds loaded 74807831229 Bytes, about 119 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162569682 Bytes

LemonLiTree · 2023-09-19T14:02:17Z

run buildall

doris-robot · 2023-09-19T14:30:52Z

TeamCity be ut coverage result:
Function Coverage: 36.75% (7979/21713)
Line Coverage: 28.82% (64047/222217)
Region Coverage: 27.72% (33244/119948)
Branch Coverage: 24.34% (17039/69992)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ea89eba906bcfec4f99b033d0e79e44e693672de_ea89eba906bcfec4f99b033d0e79e44e693672de/report/index.html

yiguolei

LGTM

doris-robot · 2023-09-20T02:29:16Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.34 seconds
stream load tsv: 604 seconds loaded 74807831229 Bytes, about 118 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162280205 Bytes

…conds_diff (apache#24114)

…conds_diff (#24114)

LemonLiTree assigned Gabriel39 Sep 12, 2023

Gabriel39 previously approved these changes Sep 17, 2023
View reviewed changes

LemonLiTree dismissed Gabriel39’s stale review via b29f9c5September 17, 2023 11:46

LemonLiTree force-pushed the millisecond_func branch from 51f5998 to b29f9c5Compare September 17, 2023 11:46

Gabriel39 approved these changes Sep 17, 2023
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 17, 2023

github-actionsBot added the reviewed label Sep 17, 2023

LemonLiTree added 2 commits September 19, 2023 12:03

support-func
8211966

fix
ea89eba

LemonLiTree force-pushed the millisecond_func branch from b29f9c5 to ea89ebaCompare September 19, 2023 04:04

yiguolei approved these changes Sep 20, 2023
View reviewed changes

Gabriel39 merged commit e59aa49 into apache:masterSep 20, 2023

JingDas pushed a commit to JingDas/doris that referenced this pull request Sep 20, 2023
[feature](datetime-func)support milliseconds_add/sub/diff and microse…
bc159e3
…conds_diff (apache#24114)

xiaokang added usercase Important user case type label dev/2.0.3 merge_conflict labels Sep 20, 2023

xiaokang pushed a commit to xiaokang/doris that referenced this pull request Sep 27, 2023
[feature](datetime-func)support milliseconds_add/sub/diff and microse…
3b7466c
…conds_diff (apache#24114)

xiaokang pushed a commit that referenced this pull request Oct 3, 2023
[feature](datetime-func)support milliseconds_add/sub/diff and microse…
a4972cf
…conds_diff (#24114)

LemonLiTree added dev/2.0.3-merged and removed dev/2.0.3 labels Oct 10, 2023

xiaokang mentioned this pull request Dec 4, 2023
Release Note 2.0.3 #27909
Closed

Uh oh!

Conversation

LemonLiTree commented Sep 8, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Further comments

Uh oh!

github-actionsBot commented Sep 8, 2023

Uh oh!

github-actionsBot commented Sep 8, 2023

Uh oh!

LemonLiTree commented Sep 8, 2023

Uh oh!

doris-robot commented Sep 8, 2023

Uh oh!

doris-robot commented Sep 8, 2023

Uh oh!

Gabriel39 left a comment

Choose a reason for hiding this comment

Uh oh!

LemonLiTree commented Sep 17, 2023

Uh oh!

github-actionsBot commented Sep 17, 2023

Uh oh!

Gabriel39 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Sep 17, 2023

Uh oh!

github-actionsBot commented Sep 17, 2023

Uh oh!

doris-robot commented Sep 17, 2023

Uh oh!

doris-robot commented Sep 17, 2023

Uh oh!

LemonLiTree commented Sep 18, 2023

Uh oh!

LemonLiTree commented Sep 18, 2023

Uh oh!

doris-robot commented Sep 18, 2023

Uh oh!

doris-robot commented Sep 18, 2023

Uh oh!

LemonLiTree commented Sep 19, 2023

Uh oh!

github-actionsBot commented Sep 19, 2023

Uh oh!

doris-robot commented Sep 19, 2023

Uh oh!

doris-robot commented Sep 19, 2023

Uh oh!

LemonLiTree commented Sep 19, 2023

Uh oh!

doris-robot commented Sep 19, 2023

Uh oh!

doris-robot commented Sep 19, 2023

Uh oh!

LemonLiTree commented Sep 19, 2023

Uh oh!

doris-robot commented Sep 19, 2023

Uh oh!

doris-robot commented Sep 19, 2023

Uh oh!

LemonLiTree commented Sep 19, 2023

Uh oh!

doris-robot commented Sep 19, 2023

Uh oh!

doris-robot commented Sep 19, 2023

Uh oh!

LemonLiTree commented Sep 19, 2023

Uh oh!

doris-robot commented Sep 19, 2023

Uh oh!

yiguolei left a comment

Choose a reason for hiding this comment

Uh oh!

doris-robot commented Sep 20, 2023

Uh oh!

Reviewers

Assignees

LemonLiTree commented Sep 8, 2023•
edited
Loading