Skip to content

[branch-2.0](fix) compile error when compiler opens -Werror and -Wunused-result#24319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiaokang merged 1 commit into from
Sep 18, 2023
Merged

[branch-2.0](fix) compile error when compiler opens -Werror and -Wunused-result #24319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions be/src/pipeline/exec/exchange_sink_buffer.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -229,7 +229,7 @@ Status ExchangeSinkBuffer::_send_rpc(InstanceLoId id) {
}
}
if (request.block) {
brpc_request->release_block();
static_cast<void>(brpc_request->release_block());
}
q.pop();
} else if (!broadcast_q.empty()) {
Expand DownExpand Up@@ -282,7 +282,7 @@ Status ExchangeSinkBuffer::_send_rpc(InstanceLoId id) {
}
}
if (request.block_holder->get_block()) {
brpc_request->release_block();
static_cast<void>(brpc_request->release_block());
}
broadcast_q.pop();
} else {
Expand Down
2 changes: 1 addition & 1 deletion be/src/vec/sink/vdata_stream_sender.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -192,7 +192,7 @@ Status Channel::send_block(PBlock* block, bool eos) {
}

if (block != nullptr) {
_brpc_request.release_block();
static_cast<void>(_brpc_request.release_block());
}
return Status::OK();
}
Expand Down
8 changes: 4 additions & 4 deletions be/src/vec/sink/vtablet_sink.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -243,7 +243,7 @@ VNodeChannel::~VNodeChannel() {
if (_open_closure != nullptr) {
delete _open_closure;
}
_cur_add_block_request.release_id();
static_cast<void>(_cur_add_block_request.release_id());
}

void VNodeChannel::clear_all_blocks() {
Expand DownExpand Up@@ -336,8 +336,8 @@ void VNodeChannel::open() {
}
_stub->tablet_writer_open(&_open_closure->cntl, &request, &_open_closure->result,
_open_closure);
request.release_id();
request.release_schema();
static_cast<void>(request.release_id());
static_cast<void>(request.release_schema());
}

Status VNodeChannel::open_wait() {
Expand DownExpand Up@@ -821,7 +821,7 @@ void VNodeChannel::cancel(const std::string& cancel_msg) {
closure->cntl.ignore_eovercrowded();
}
_stub->tablet_writer_cancel(&closure->cntl, &request, &closure->result, closure);
request.release_id();
static_cast<void>(request.release_id());
}

bool VNodeChannel::is_send_data_rpc_done() const {
Expand Down