Skip to content

[fix](agg) need to call 'set_version' in nested functions - #24381

Merged
yiguolei merged 2 commits into
apache:masterfrom
mrhhsg:fix_nested_function
Sep 15, 2023
Merged

[fix](agg) need to call 'set_version' in nested functions#24381
yiguolei merged 2 commits into
apache:masterfrom
mrhhsg:fix_nested_function

Conversation

@mrhhsg

Copy link
Copy Markdown
Member

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@mrhhsg

Copy link
Copy Markdown
MemberAuthor

run buildall

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.95% (7972/21578)
Line Coverage: 28.91% (63882/221006)
Region Coverage: 27.84% (33155/119110)
Branch Coverage: 24.40% (17010/69706)
Coverage Report: http://coverage.selectdb-in.cc/coverage/43be53a61e2029721513dbf8df7af93bcab8564a_43be53a61e2029721513dbf8df7af93bcab8564a/report/index.html

@doris-robot

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.24 seconds
stream load tsv: 596 seconds loaded 74807831229 Bytes, about 119 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162545626 Bytes

@mrhhsg

Copy link
Copy Markdown
MemberAuthor

run buildall

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.78 seconds
stream load tsv: 595 seconds loaded 74807831229 Bytes, about 119 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162448905 Bytes

@doris-robot

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.96% (7974/21577)
Line Coverage: 28.92% (63909/221005)
Region Coverage: 27.85% (33171/119107)
Branch Coverage: 24.42% (17021/69706)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0faca898bc7ffd2619a969ef48de2a542c998826_0faca898bc7ffd2619a969ef48de2a542c998826/report/index.html

@yiguolei

Copy link
Copy Markdown
Contributor

run buildall

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.96% (7974/21577)
Line Coverage: 28.91% (63890/221019)
Region Coverage: 27.84% (33156/119111)
Branch Coverage: 24.40% (17012/69710)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4c257f1a6dbe90e897fc90691f5049aa57b4104e_4c257f1a6dbe90e897fc90691f5049aa57b4104e/report/index.html

@doris-robot

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.57 seconds
stream load tsv: 599 seconds loaded 74807831229 Bytes, about 119 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162271009 Bytes

@jacktenggjacktengg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yiguoleiyiguolei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 15, 2023
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@yiguolei
yiguolei merged commit b4d4460 into apache:masterSep 15, 2023
xiaokang pushed a commit that referenced this pull request Sep 15, 2023
xiaokang added a commit that referenced this pull request Sep 16, 2023
xiaokang added a commit that referenced this pull request Sep 17, 2023
@xiaokangxiaokang mentioned this pull request Sep 28, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.2-mergedp0_breviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@mrhhsg@doris-robot@yiguolei@jacktengg@xiaokang