Skip to content

[for-test-only] Revert "[schedule](pipeline) Remove wait schedule time in pipeline qu… - #24472

Merged
yiguolei merged 1 commit into
apache:masterfrom
shuke987:core_test
Sep 18, 2023
Merged

[for-test-only] Revert "[schedule](pipeline) Remove wait schedule time in pipeline qu…#24472
yiguolei merged 1 commit into
apache:masterfrom
shuke987:core_test

Conversation

@shuke987

@shuke987shuke987 commented Sep 15, 2023

Copy link
Copy Markdown
Contributor

…ery engine (#23994)"

This reverts commit 32a7eef.

@github-actions

github-actionsBot commented Sep 15, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Sep 15, 2023
@github-actions

github-actionsBot commented Sep 15, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@shuke987

shuke987 commented Sep 15, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Sep 15, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@shuke987shuke987 changed the title Revert "[schedule](pipeline) Remove wait schedule time in pipeline qu…[for-test-only] Revert "[schedule](pipeline) Remove wait schedule time in pipeline qu…Sep 15, 2023
@doris-robot

doris-robot commented Sep 15, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.86 seconds
stream load tsv: 594 seconds loaded 74807831229 Bytes, about 120 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162443168 Bytes

@doris-robot

doris-robot commented Sep 15, 2023

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.85% (7980/21656)
Line Coverage: 28.87% (64027/221779)
Region Coverage: 27.79% (33209/119504)
Branch Coverage: 24.39% (17046/69894)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7b10cbce89a7f0da5c73f00ba23f8d56f7ae55ce_7b10cbce89a7f0da5c73f00ba23f8d56f7ae55ce/report/index.html

yiguolei
yiguolei approved these changes Sep 18, 2023
View reviewed changes

@yiguoleiyiguolei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei
yiguolei merged commit 591aeaa into apache:masterSep 18, 2023
@shuke987
shuke987 deleted the core_test branch November 13, 2023 06:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@engleflyengleflyenglefly approved these changes
@yiguoleiyiguoleiyiguolei approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shuke987@doris-robot@englefly@yiguolei@xiaokang