Skip to content

[Fix](binlog) Add more log for ingest_binlog && Fix ingest_binlog not rewrite rowset_meta tablet_uid - #24617

Merged
yiguolei merged 2 commits into
apache:masterfrom
JackDrogon:hotfix/ingest_binlog_rewrite_tablet_uid
Sep 21, 2023
Merged

[Fix](binlog) Add more log for ingest_binlog && Fix ingest_binlog not rewrite rowset_meta tablet_uid#24617
yiguolei merged 2 commits into
apache:masterfrom
JackDrogon:hotfix/ingest_binlog_rewrite_tablet_uid

Conversation

@JackDrogon

@JackDrogonJackDrogon commented Sep 19, 2023

Copy link
Copy Markdown
Contributor

Proposed changes

Add more log for ingest_binlog && Fix ingest_binlog not rewrite rowset_meta tablet_uid

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@JackDrogon
Add more log for ingest_binlog && Fix ingest_binlog not rewrite
12b882c
rowset_meta tablet_uid
Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
@JackDrogon

JackDrogon commented Sep 19, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Sep 19, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

dataroaring
dataroaring previously approved these changes Sep 19, 2023
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Sep 19, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Sep 19, 2023
@github-actions

github-actionsBot commented Sep 19, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@doris-robot

doris-robot commented Sep 19, 2023

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.83% (7979/21667)
Line Coverage: 28.85% (64028/221940)
Region Coverage: 27.74% (33228/119779)
Branch Coverage: 24.36% (17029/69910)
Coverage Report: http://coverage.selectdb-in.cc/coverage/12b882c48f90f6979899732fe25535bd98f73215_12b882c48f90f6979899732fe25535bd98f73215/report/index.html

@JackDrogon
Add lost thrift TDebugProtocol
37259f7
Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Sep 20, 2023
@JackDrogon

JackDrogon commented Sep 20, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Sep 20, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Sep 20, 2023

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.68% (7990/21785)
Line Coverage: 28.71% (64079/223232)
Region Coverage: 27.62% (33266/120458)
Branch Coverage: 24.24% (17045/70304)
Coverage Report: http://coverage.selectdb-in.cc/coverage/37259f7c1115ab662e1563ccc73799fb5ab89767_37259f7c1115ab662e1563ccc73799fb5ab89767/report/index.html

@doris-robot

doris-robot commented Sep 20, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.71 seconds
stream load tsv: 597 seconds loaded 74807831229 Bytes, about 119 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162373639 Bytes

dataroaring
dataroaring approved these changes Sep 20, 2023
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Sep 20, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 20, 2023
yiguolei
yiguolei approved these changes Sep 21, 2023
View reviewed changes

@yiguoleiyiguolei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei
yiguolei merged commit ee5b307 into apache:masterSep 21, 2023
xiaokang pushed a commit that referenced this pull request Sep 21, 2023
@JackDrogon@xiaokang
[Fix](binlog) Add more log for ingest_binlog && Fix ingest_binlog not…
832e18d
… rewrite rowset_meta tablet_uid (#24617)
* Add more log for ingest_binlog && Fix ingest_binlog not rewrite
rowset_meta tablet_uid
Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
* Add lost thrift TDebugProtocol
Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
---------
Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
@xiaokangxiaokang mentioned this pull request Sep 28, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguoleiyiguoleiyiguolei approved these changes
@dataroaringdataroaringdataroaring approved these changes
+1 more reviewer
@ByteYueByteYueByteYue approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.2-mergedp0_breviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JackDrogon@doris-robot@yiguolei@ByteYue@dataroaring@xiaokang