Uh oh!
There was an error while loading. Please reload this page.
[fix](broker) fix broker read issue - #24635
Merged
Merged
Conversation
morningman
commented
Sep 19, 2023
ContributorAuthor
run buildall |
Contributor
PR approved by anyone and no changes requested. |
Contributor
PR approved by at least one committer and no changes requested. |
JingDas pushed a commit
to JingDas/doris
that referenced
this pull request
Sep 20, 2023
The given "length" of broker's pread() method is the buffer length, not the length required from file. So it may larger than the file length. So we should return all read data, instead of return EOF when `read()` method return -1 I will add regression test case later when the framework support broker process.
xiaokang pushed a commit
that referenced
this pull request
Sep 20, 2023
The given "length" of broker's pread() method is the buffer length, not the length required from file. So it may larger than the file length. So we should return all read data, instead of return EOF when `read()` method return -1 I will add regression test case later when the framework support broker process.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The given "length" of broker's pread() method is the buffer length, not the length required from file.
So it may larger than the file length.
So we should return all read data, instead of return EOF when
read()method return -1I will add regression test case later when the framework support broker process.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...