Uh oh!
There was an error while loading. Please reload this page.
[Bug](materialized-view) enable rewrite on select materialized index with aggregate mode - #24691
Conversation
BiteTheDDDDt
commented
Sep 20, 2023
run buildall |
doris-robot
commented
Sep 20, 2023
(From new machine)TeamCity pipeline, clickbench performance test result: |
BiteTheDDDDt
commented
Sep 20, 2023
run buildall |
BiteTheDDDDt
commented
Sep 21, 2023
run buildall |
doris-robot
commented
Sep 21, 2023
(From new machine)TeamCity pipeline, clickbench performance test result: |
| } | ||
| // rollup or base column not have define expr | ||
| public boolean haveDefineExpr() { |
| } | ||
| Set<MaterializedIndex> candidatesWithoutRewriting = new HashSet<>(); | ||
| if (!table.isDupKeysOrMergeOnWrite() && scan.getPreAggStatus().isOff()) { |
There was a problem hiding this comment.
could u add some comment to explain why add scan.getPreAggStatus().isOff()
Uh oh!
There was an error while loading. Please reload this page.
BiteTheDDDDt
commented
Sep 25, 2023
run buildall |
1 similar comment
BiteTheDDDDt
commented
Sep 25, 2023
run buildall |
BiteTheDDDDt
commented
Sep 25, 2023
run p0 |
BiteTheDDDDt
commented
Sep 25, 2023
run ckbench |
BiteTheDDDDt
commented
Sep 26, 2023
run buildall |
doris-robot
commented
Sep 26, 2023
(From new machine)TeamCity pipeline, clickbench performance test result: |
BiteTheDDDDt
commented
Sep 26, 2023
run buildall |
doris-robot
commented
Sep 26, 2023
(From new machine)TeamCity pipeline, clickbench performance test result: |
BiteTheDDDDt
commented
Sep 26, 2023
run buildall |
doris-robot
commented
Sep 26, 2023
(From new machine)TeamCity pipeline, clickbench performance test result: |
BiteTheDDDDt
commented
Sep 26, 2023
run buildall |
doris-robot
commented
Sep 26, 2023
(From new machine)TeamCity pipeline, clickbench performance test result: |
BiteTheDDDDt
commented
Sep 26, 2023
run buildall |
BiteTheDDDDt
commented
Sep 26, 2023
run buildall |
doris-robot
commented
Sep 26, 2023
(From new machine)TeamCity pipeline, clickbench performance test result: |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
…with aggregate mode (apache#24691) enable rewrite on select materialized index with aggregate mode
…with aggregate mode (#24691) enable rewrite on select materialized index with aggregate mode
…with aggregate mode (apache#24691) enable rewrite on select materialized index with aggregate mode
…with aggregate mode (apache#24691) enable rewrite on select materialized index with aggregate mode
Proposed changes
enable rewrite on select materialized index with aggregate mode
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...