Skip to content

[Fix](merge-on-write) enable_unique_key_partial_update should be forwarded to master - #24697

Merged
yiguolei merged 1 commit into
apache:masterfrom
bobhan1:fix-need-forward
Sep 21, 2023
Merged

[Fix](merge-on-write) enable_unique_key_partial_update should be forwarded to master#24697
yiguolei merged 1 commit into
apache:masterfrom
bobhan1:fix-need-forward

Conversation

@bobhan1

Copy link
Copy Markdown
Contributor

Proposed changes

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@bobhan1

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.9 seconds
stream load tsv: 612 seconds loaded 74807831229 Bytes, about 116 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162473192 Bytes

@zhannngchenzhannngchen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 20, 2023
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yiguoleiyiguolei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei
yiguolei merged commit b25c3e2 into apache:masterSep 21, 2023
xiaokang pushed a commit that referenced this pull request Sep 21, 2023
@xiaokangxiaokang mentioned this pull request Sep 28, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.2-mergedmerge_conflictp0_breviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@bobhan1@doris-robot@yiguolei@zhannngchen@xiaokang@shuke987@wm1581066