Skip to content

Revert "[Feature](merge-on-write)Support ignore mode for merge-on-write unique table (#21773)" - #24731

Merged
zhannngchen merged 1 commit into
apache:masterfrom
bobhan1:revert-insert-ignore
Sep 21, 2023
Merged

Revert "[Feature](merge-on-write)Support ignore mode for merge-on-write unique table (#21773)"#24731
zhannngchen merged 1 commit into
apache:masterfrom
bobhan1:revert-insert-ignore

Conversation

@bobhan1

@bobhan1bobhan1 commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

Proposed changes

This reverts commit 3ee89ae.
We think ignore mode may be too complicate to support after discussion, so we disable it currently.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@bobhan1

bobhan1 commented Sep 21, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

zhannngchen
zhannngchen previously approved these changes Sep 21, 2023
View reviewed changes

@zhannngchenzhannngchen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 21, 2023
@github-actions

github-actionsBot commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@github-actions

github-actionsBot commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Sep 21, 2023
@bobhan1

bobhan1 commented Sep 21, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Sep 21, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.75 seconds
stream load tsv: 592 seconds loaded 74807831229 Bytes, about 120 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162225535 Bytes

@doris-robot

doris-robot commented Sep 21, 2023

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.40% (8016/22023)
Line Coverage: 28.68% (64352/224343)
Region Coverage: 27.58% (33402/121131)
Branch Coverage: 24.24% (17095/70524)
Coverage Report: http://coverage.selectdb-in.cc/coverage/df03f778d74c97ab0cd6b6a4c214aa036e6efa98_df03f778d74c97ab0cd6b6a4c214aa036e6efa98/report/index.html

@doris-robot

doris-robot commented Sep 21, 2023

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.40% (8016/22023)
Line Coverage: 28.68% (64346/224343)
Region Coverage: 27.58% (33407/121131)
Branch Coverage: 24.24% (17097/70524)
Coverage Report: http://coverage.selectdb-in.cc/coverage/84e73d04fe35a960c93a7221f96d126dfd81ab41_84e73d04fe35a960c93a7221f96d126dfd81ab41/report/index.html

zhannngchen
zhannngchen approved these changes Sep 21, 2023
View reviewed changes

@zhannngchenzhannngchen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 21, 2023
@github-actions

github-actionsBot commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

dataroaring
dataroaring approved these changes Sep 21, 2023
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhannngchen
zhannngchen merged commit 58ab25c into apache:masterSep 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhannngchenzhannngchenzhannngchen approved these changes
@Yukang-LianYukang-LianYukang-Lian approved these changes
@dataroaringdataroaringdataroaring approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bobhan1@doris-robot@zhannngchen@Yukang-Lian@dataroaring