Uh oh!
There was an error while loading. Please reload this page.
[Improve](inverted index) improve match performance without index - #24751
Conversation
airborne12
commented
Sep 21, 2023
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
doris-robot
commented
Sep 21, 2023
TeamCity be ut coverage result: |
f692b6d to
a6dde5eCompareairborne12
commented
Sep 21, 2023
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
a6dde5e to
97feec2Compareairborne12
commented
Sep 22, 2023
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
97feec2 to
352610bCompareairborne12
commented
Sep 22, 2023
run buildall |
| query_type == InvertedIndexQueryType::MATCH_ALL_QUERY || | ||
| query_type == InvertedIndexQueryType::EQUAL_QUERY) { | ||
| std::wstring wstr_tokens; | ||
| std::string str_tokens; |
There was a problem hiding this comment.
warning: variable 'str_tokens' is not initialized [cppcoreguidelines-init-variables]
| std::string str_tokens; | |
| std::string str_tokens = 0; |
| auto reader = doris::segment_v2::InvertedIndexReader::create_reader( | ||
| &inverted_index_ctx, tokenize_str.to_string()); | ||
| std::vector<std::string> query_tokens = |
There was a problem hiding this comment.
warning: variable 'query_tokens' is not initialized [cppcoreguidelines-init-variables]
| std::vector<std::string> query_tokens = | |
| std::vector<std::string> query_tokens =0 = |
doris-robot
commented
Sep 22, 2023
TeamCity be ut coverage result: |
airborne12
commented
Sep 22, 2023
run buildall |
doris-robot
commented
Sep 22, 2023
TeamCity be ut coverage result: |
doris-robot
commented
Sep 22, 2023
(From new machine)TeamCity pipeline, clickbench performance test result: |
Proposed changes
Issue Number: close #xxx
improve performance for match without index, from 2 min 34.54 sec to 9.16s, on httplogs dataset.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...