Skip to content

[FIX](serde) fix map/array deserialize string with quote pair - #24808

Merged
xiaokang merged 2 commits into
apache:masterfrom
amorynan:fix-map-array-quote-pair
Sep 22, 2023
Merged

[FIX](serde) fix map/array deserialize string with quote pair#24808
xiaokang merged 2 commits into
apache:masterfrom
amorynan:fix-map-array-quote-pair

Conversation

@amorynan

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #xxx
fix map/array deserialize string with quote pair
Now we deserialize string item with quote can be " and ' which non-pair also can be deserialize success, but it should be pair appear in single string

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@amorynan

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.34% (8023/22079)
Line Coverage: 28.65% (64449/224989)
Region Coverage: 27.56% (33484/121502)
Branch Coverage: 24.23% (17134/70726)
Coverage Report: http://coverage.selectdb-in.cc/coverage/8d428716263a0211d607017249265221930f2139_8d428716263a0211d607017249265221930f2139/report/index.html

@doris-robot

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.59 seconds
stream load tsv: 564 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162457626 Bytes

@xiaokangxiaokang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 22, 2023
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@eldenmooneldenmoon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaokang

Copy link
Copy Markdown
Contributor

run buildall

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.27% (8021/22112)
Line Coverage: 28.60% (64432/225274)
Region Coverage: 27.49% (33469/121730)
Branch Coverage: 24.17% (17121/70836)
Coverage Report: http://coverage.selectdb-in.cc/coverage/77a332bdea3f8b5f49454fe52344244f2727fea3_77a332bdea3f8b5f49454fe52344244f2727fea3/report/index.html

@doris-robot

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.23 seconds
stream load tsv: 561 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.5 seconds inserted 10000000 Rows, about 338K ops/s
storage size: 17162334577 Bytes

@xiaokangxiaokang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaokang
xiaokang merged commit ce79711 into apache:masterSep 22, 2023
@xiaokangxiaokang mentioned this pull request Sep 28, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.2-mergedp0_breviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@amorynan@doris-robot@xiaokang@eldenmoon