Skip to content

[Enhancement](log) Improve Safety and Robustness of Log4j Configuration - #24861

Merged
zy-kkk merged 1 commit into
apache:masterfrom
zy-kkk:log_fix
Oct 9, 2023
Merged

[Enhancement](log) Improve Safety and Robustness of Log4j Configuration#24861
zy-kkk merged 1 commit into
apache:masterfrom
zy-kkk:log_fix

Conversation

@zy-kkk

Copy link
Copy Markdown
Member

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@liugddxliugddx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@zy-kkk

Copy link
Copy Markdown
MemberAuthor

run buildall

@JNSimbaJNSimba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 9, 2023
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@doris-robot

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.83 seconds
stream load tsv: 557 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162174790 Bytes

@zy-kkk
zy-kkk merged commit 400b9f2 into apache:masterOct 9, 2023
@zy-kkk
zy-kkk deleted the log_fix branch October 9, 2023 11:44
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@xiaokangxiaokang mentioned this pull request Dec 4, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.3-mergedreviewedsecurity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@zy-kkk@doris-robot@JNSimba@CalvinKirs@DongLiang-0@liugddx@xiaokang