Skip to content

[log](compaction) add more stats for compaction log - #24984

Merged
zhannngchen merged 1 commit into
apache:masterfrom
zhannngchen:add_more_stats_for_compaction_log
Sep 28, 2023
Merged

[log](compaction) add more stats for compaction log#24984
zhannngchen merged 1 commit into
apache:masterfrom
zhannngchen:add_more_stats_for_compaction_log

Conversation

@zhannngchen

@zhannngchenzhannngchen commented Sep 27, 2023

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #xxx

print filtered rows and merged rows for compaction log

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@zhannngchen

zhannngchen commented Sep 27, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Sep 27, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Sep 27, 2023

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.31% (8136/22405)
Line Coverage: 28.47% (65101/228705)
Region Coverage: 27.40% (33721/123078)
Branch Coverage: 24.06% (17210/71528)
Coverage Report: http://coverage.selectdb-in.cc/coverage/cbaffb460b6c672aa5c598f2ab3688ca7ad652fd_cbaffb460b6c672aa5c598f2ab3688ca7ad652fd/report/index.html

liaoxin01
liaoxin01 approved these changes Sep 27, 2023
View reviewed changes

@liaoxin01liaoxin01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Sep 27, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@doris-robot

doris-robot commented Sep 27, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.47 seconds
stream load tsv: 559 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162649810 Bytes

yiguolei
yiguolei approved these changes Sep 28, 2023
View reviewed changes

@yiguoleiyiguolei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 28, 2023
@github-actions

github-actionsBot commented Sep 28, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@zhannngchen
zhannngchen merged commit 2ec50dc into apache:masterSep 28, 2023
vinlee19 pushed a commit to vinlee19/doris that referenced this pull request Oct 7, 2023
@zhannngchen@vinlee19
[log](compaction) add more stats for compaction log (apache#24984)
56c6898
zhannngchen added a commit to zhannngchen/incubator-doris that referenced this pull request Nov 1, 2023
@zhannngchen
[log](compaction) add more stats for compaction log (apache#24984)
9756593
@zhannngchenzhannngchen mentioned this pull request Nov 1, 2023
Merged
xiaokang pushed a commit that referenced this pull request Nov 1, 2023
@zhannngchen
[log](compaction) add more stats for compaction log (#24984) (#26217)
b27e07a
gnehil pushed a commit to gnehil/doris that referenced this pull request Dec 4, 2023
@zhannngchengnehil
[log](compaction) add more stats for compaction log (apache#24984) (a…
5e50480
…pache#26217)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguoleiyiguoleiyiguolei approved these changes
@liaoxin01liaoxin01liaoxin01 approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.3-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zhannngchen@doris-robot@yiguolei@liaoxin01@xiaokang