Skip to content

[fix](multicatalog)fix jdbc catalog current_timestamp default - #25016

Merged
zy-kkk merged 4 commits into
apache:masterfrom
vinlee19:fix_catalog_default
Oct 7, 2023
Merged

[fix](multicatalog)fix jdbc catalog current_timestamp default#25016
zy-kkk merged 4 commits into
apache:masterfrom
vinlee19:fix_catalog_default

Conversation

@vinlee19

Copy link
Copy Markdown
Contributor

Proposed changes

image

This problem is caused when you read table data from Mariadb where the datatime type default value is set to current_timestamp().

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@vinlee19

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.63 seconds
stream load tsv: 564 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17162257506 Bytes

@wm1581066wm1581066 added dev/2.0.3 usercase Important user case type label labels Sep 29, 2023
@zy-kkkzy-kkk self-assigned this Oct 3, 2023

@vinlee19vinlee19 left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run buildall

@vinlee19
vinlee19 requested a review from zy-kkkOctober 5, 2023 02:10
@zy-kkk

Copy link
Copy Markdown
Member

run buildall

1 similar comment
@shuke987

Copy link
Copy Markdown
Contributor

run buildall

@doris-robot

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.92 seconds
stream load tsv: 581 seconds loaded 74807831229 Bytes, about 122 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162328708 Bytes

@zy-kkkzy-kkk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LemonLiTreeLemonLiTree left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 7, 2023
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@zy-kkk
zy-kkk merged commit 47694c5 into apache:masterOct 7, 2023
vinlee19 added a commit to vinlee19/doris that referenced this pull request Oct 7, 2023
…e#25016)
This problem is caused when you read table data from Mariadb where the datatime type default value is set to current_timestamp().
xiaokang pushed a commit that referenced this pull request Oct 7, 2023
This problem is caused when you read table data from Mariadb where the datatime type default value is set to current_timestamp().
@xiaokangxiaokang mentioned this pull request Dec 4, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.3-mergedreviewedusercaseImportant user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@vinlee19@doris-robot@zy-kkk@shuke987@LemonLiTree@xiaokang@wm1581066