Skip to content

[fix](jdbc catalog) fix jdbc catalog read bitmap data crash - #25034

Merged
dataroaring merged 1 commit into
apache:masterfrom
zy-kkk:fix_jdbc_bitmap_crash
Oct 3, 2023
Merged

[fix](jdbc catalog) fix jdbc catalog read bitmap data crash#25034
dataroaring merged 1 commit into
apache:masterfrom
zy-kkk:fix_jdbc_bitmap_crash

Conversation

@zy-kkk

@zy-kkkzy-kkk commented Oct 1, 2023

Copy link
Copy Markdown
Member

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@zy-kkk

zy-kkk commented Oct 1, 2023

Copy link
Copy Markdown
MemberAuthor

run buildall

@github-actions

github-actionsBot commented Oct 1, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Oct 1, 2023

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.28% (8143/22442)
Line Coverage: 28.43% (65144/229178)
Region Coverage: 27.37% (33740/123293)
Branch Coverage: 24.04% (17210/71602)
Coverage Report: http://coverage.selectdb-in.cc/coverage/76c23a811d1cd506f912117de5da8add0e59fd91_76c23a811d1cd506f912117de5da8add0e59fd91/report/index.html

@doris-robot

doris-robot commented Oct 1, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.34 seconds
stream load tsv: 579 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162436398 Bytes

@zy-kkk

zy-kkk commented Oct 2, 2023

Copy link
Copy Markdown
MemberAuthor

run p0

@zy-kkk

zy-kkk commented Oct 2, 2023

Copy link
Copy Markdown
MemberAuthor

run p1

dataroaring
dataroaring approved these changes Oct 3, 2023
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 3, 2023
@github-actions

github-actionsBot commented Oct 3, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Oct 3, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@dataroaring
dataroaring merged commit 6e836fe into apache:masterOct 3, 2023
@zy-kkk
zy-kkk deleted the fix_jdbc_bitmap_crash branch October 3, 2023 12:54
vinlee19 pushed a commit to vinlee19/doris that referenced this pull request Oct 7, 2023
@zy-kkk@vinlee19
[fix](jdbc catalog) fix jdbc catalog read bitmap data crash (apache#2…
fe84c96
…5034)
xiaokang pushed a commit that referenced this pull request Oct 7, 2023
@zy-kkk@xiaokang
[fix](jdbc catalog) fix jdbc catalog read bitmap data crash (#25034)
a227cda
@xiaokangxiaokang mentioned this pull request Dec 4, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bobhan1bobhan1bobhan1 approved these changes
@dataroaringdataroaringdataroaring approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.3-mergedp0_wreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zy-kkk@doris-robot@bobhan1@dataroaring@xiaokang