Skip to content

[FIX](regresstest) fix cases for test_nested_types_insert_into_with_s3 - #25228

Merged
xiaokang merged 1 commit into
apache:masterfrom
amorynan:fix-regresstest
Oct 13, 2023
Merged

[FIX](regresstest) fix cases for test_nested_types_insert_into_with_s3#25228
xiaokang merged 1 commit into
apache:masterfrom
amorynan:fix-regresstest

Conversation

@amorynan

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #xxx
here need truncate table for insert into same table with parquet file which data is not same with orc file,
so next select from parquet may has 50% chance to fail
we can truncate table first.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@amorynan

Copy link
Copy Markdown
ContributorAuthor

run buildall

@amorynan

Copy link
Copy Markdown
ContributorAuthor

run p0

@hello-stephenhello-stephen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hello-stephen

Copy link
Copy Markdown
Contributor

run p0

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@amorynan

Copy link
Copy Markdown
ContributorAuthor

run p0

1 similar comment
@amorynan

Copy link
Copy Markdown
ContributorAuthor

run p0

@xiaokangxiaokang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 12, 2023
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.3-mergedreviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@amorynan@hello-stephen@xiaokang