Skip to content

[fix](load) handle Status in beta rowset writer - #25293

Merged
dataroaring merged 3 commits into
apache:masterfrom
kaijchen:handle-status
Oct 12, 2023
Merged

[fix](load) handle Status in beta rowset writer#25293
dataroaring merged 3 commits into
apache:masterfrom
kaijchen:handle-status

Conversation

@kaijchen

@kaijchenkaijchen commented Oct 11, 2023

Copy link
Copy Markdown
Member

Proposed changes

Handle Status returned from subroutine in beta rowset writer.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions

github-actionsBot commented Oct 11, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@dataroaring

dataroaring commented Oct 11, 2023

Copy link
Copy Markdown
Contributor

run buildall

@doris-robot

doris-robot commented Oct 11, 2023

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.24% (8149/22486)
Line Coverage: 28.36% (65180/229863)
Region Coverage: 27.28% (33776/123812)
Branch Coverage: 23.98% (17212/71774)
Coverage Report: http://coverage.selectdb-in.cc/coverage/af4cb18fc94af20fffe30e5ffbe55587a080a8e1_af4cb18fc94af20fffe30e5ffbe55587a080a8e1/report/index.html

@doris-robot

doris-robot commented Oct 11, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.21 seconds
stream load tsv: 558 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162313451 Bytes

freemandealer
freemandealer requested changes Oct 12, 2023
View reviewed changes
Comment threadbe/src/olap/rowset/beta_rowset_writer.cpp Outdated

if (_segcompaction_worker.get_file_writer()) {
static_cast<void>(_segcompaction_worker.get_file_writer()->close());
WARN_IF_ERROR(_segcompaction_worker.get_file_writer()->close(),

@freemandealerfreemandealerOct 12, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Printing a warning here would not be enough. Since data may not be synced to disk if file writers close fail, causing data corruption in silence. I suggest we should return nullptr if shit happens.

@kaijchen

kaijchen commented Oct 12, 2023

Copy link
Copy Markdown
MemberAuthor

run buildall

@github-actions

github-actionsBot commented Oct 12, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions

github-actionsBot commented Oct 12, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Oct 12, 2023

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.23% (8154/22509)
Line Coverage: 28.34% (65281/230380)
Region Coverage: 27.05% (33809/124981)
Branch Coverage: 23.88% (17251/72232)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f8affcc98291a52f8134ec24aedcb888d6d664c7_f8affcc98291a52f8134ec24aedcb888d6d664c7/report/index.html

@doris-robot

doris-robot commented Oct 12, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.21 seconds
stream load tsv: 578 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162447747 Bytes

freemandealer
freemandealer approved these changes Oct 12, 2023
View reviewed changes

@freemandealerfreemandealer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dataroaring
dataroaring approved these changes Oct 12, 2023
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 12, 2023
@github-actions

github-actionsBot commented Oct 12, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Oct 12, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@dataroaring
dataroaring merged commit e17f3b7 into apache:masterOct 12, 2023
@kaijchen
kaijchen deleted the handle-status branch October 12, 2023 09:09
kaijchen added a commit to kaijchen/doris that referenced this pull request Oct 12, 2023
@kaijchen
[fix](load) handle Status in beta rowset writer (apache#25293)
4b179a3
@kaijchenkaijchen mentioned this pull request Oct 12, 2023
Merged
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@kaijchen王翔宇
[fix](load) handle Status in beta rowset writer (apache#25293)
0606cce
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freemandealerfreemandealerfreemandealer approved these changes
@dataroaringdataroaringdataroaring approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.3-mergedmerge_conflictreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kaijchen@dataroaring@doris-robot@freemandealer@xiaokang