Skip to content

[fix](planner) Fix select table tablet not effective - #25378

Merged
yiguolei merged 3 commits into
apache:masterfrom
xinyiZzz:20231012_fix_table_sample
Oct 25, 2023
Merged

[fix](planner) Fix select table tablet not effective#25378
yiguolei merged 3 commits into
apache:masterfrom
xinyiZzz:20231012_fix_table_sample

Conversation

@xinyiZzz

@xinyiZzzxinyiZzz commented Oct 12, 2023

Copy link
Copy Markdown
Contributor

Proposed changes

  1. Fix select table tablet not effective, table distributed by random.
  2. If tabletID specified in query does not exist in this partition, skip scan partition.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@xinyiZzz

xinyiZzz commented Oct 12, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Oct 12, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.7 seconds
stream load tsv: 571 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162375825 Bytes

@xinyiZzz
xinyiZzzforce-pushed the 20231012_fix_table_sample branch from 5fe8146 to 01d4a4aCompareOctober 13, 2023 07:18
@xinyiZzz

xinyiZzz commented Oct 13, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

1 similar comment
@xinyiZzz

xinyiZzz commented Oct 13, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Oct 13, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.38 seconds
stream load tsv: 555 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162138773 Bytes

@doris-robot

doris-robot commented Oct 13, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.25 seconds
stream load tsv: 557 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162177863 Bytes

@xiaokangxiaokang added the usercase Important user case type label label Oct 15, 2023
xiaokang
xiaokang reviewed Oct 24, 2023
View reviewed changes
Comment threadfe/fe-core/src/test/java/org/apache/doris/analysis/SelectStmtTest.java Outdated
}

@Test
public void testSelectSampleTable() throws Exception {

@xiaokangxiaokangOct 24, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add case for random bucket.

@xinyiZzzxinyiZzzOct 24, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment threadfe/fe-core/src/main/java/org/apache/doris/planner/OlapScanNode.java
if (tabletIds != null) {
tabletIds.retainAll(sampleTabletIds);
} else {
tabletIds = sampleTabletIds;

@xiaokangxiaokangOct 24, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this logic related to random bucket?

@xinyiZzzxinyiZzzOct 24, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the tabletIds returned by random bucketing distributionPrune are null.

@xinyiZzz

xinyiZzz commented Oct 24, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Oct 24, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.46 seconds
stream load tsv: 554 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162166641 Bytes

@xinyiZzz
xinyiZzzforce-pushed the 20231012_fix_table_sample branch from 411bd70 to 8c31ae9CompareOctober 24, 2023 02:46
@xinyiZzz

xinyiZzz commented Oct 24, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Oct 24, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.64 seconds
stream load tsv: 555 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17161942222 Bytes

xiaokang
xiaokang approved these changes Oct 25, 2023
View reviewed changes

@xiaokangxiaokang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 25, 2023
@github-actions

github-actionsBot commented Oct 25, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Oct 25, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

yiguolei
yiguolei approved these changes Oct 25, 2023
View reviewed changes

@yiguoleiyiguolei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei
yiguolei merged commit a919ef6 into apache:masterOct 25, 2023
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@xinyiZzz王翔宇
[fix](planner) Fixselect table tabletnot effective (apache#25378)
b4bf784
Fix select table tablet not effective, table distributed by random.
If tabletID specified in query does not exist in this partition, skip scan partition.
xiaokang pushed a commit to xiaokang/doris that referenced this pull request Oct 31, 2023
@xinyiZzz@xiaokang
[fix](planner) Fixselect table tabletnot effective (apache#25378)
afc0a5e
Fix select table tablet not effective, table distributed by random.
If tabletID specified in query does not exist in this partition, skip scan partition.
xiaokang pushed a commit to xiaokang/doris that referenced this pull request Nov 1, 2023
@xinyiZzz@xiaokang
[fix](planner) Fixselect table tabletnot effective (apache#25378)
1f5962b
Fix select table tablet not effective, table distributed by random.
If tabletID specified in query does not exist in this partition, skip scan partition.
gnehil pushed a commit to gnehil/doris that referenced this pull request Dec 4, 2023
@xinyiZzzgnehil
[fix](planner) Fixselect table tabletnot effective (apache#25378)
4f292d8
Fix select table tablet not effective, table distributed by random.
If tabletID specified in query does not exist in this partition, skip scan partition.
@xiaokangxiaokang mentioned this pull request Dec 4, 2023
Closed
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@xinyiZzz胥剑旭
[fix](planner) Fixselect table tabletnot effective (apache#25378)
c589f43
Fix select table tablet not effective, table distributed by random.
If tabletID specified in query does not exist in this partition, skip scan partition.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaokangxiaokangxiaokang approved these changes
@yiguoleiyiguoleiyiguolei approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.3-mergedreviewedusercaseImportant user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xinyiZzz@doris-robot@xiaokang@yiguolei