Skip to content

[refactor](nereids)align node id in explain with nereids node id #25068 - #25407

Merged
xiaokang merged 1 commit into
apache:branch-2.0from
englefly:25068-branch-2.0
Oct 13, 2023
Merged

[refactor](nereids)align node id in explain with nereids node id #25068#25407
xiaokang merged 1 commit into
apache:branch-2.0from
englefly:25068-branch-2.0

Conversation

@englefly

Copy link
Copy Markdown
Contributor

Proposed changes

cherry pick pr 25068 for branch 2.0

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@englefly
englefly changed the base branch from master to branch-2.0October 13, 2023 06:26
@xiaokang

Copy link
Copy Markdown
Contributor

run buildall

@xiaokangxiaokang changed the title [pick](nerieds)pr 25068 for branch 2.0[refactor](nereids)align node id in explain with nereids node id #25068Oct 13, 2023
@hello-stephen

Copy link
Copy Markdown
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.47 seconds
stream load tsv: 562 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17167639225 Bytes

it is painful to align node in `explain` and node in `explain physical plan`, since they use two different sets of node IDs.
This pr makes 'explain' command use node IDs of their correspond node in 'explain physical plan'
(cherry picked from commit ffaa145)
@englefly

Copy link
Copy Markdown
ContributorAuthor

run buildall

@xiaokang
xiaokang merged commit 2a656d9 into apache:branch-2.0Oct 13, 2023
@englefly
englefly deleted the 25068-branch-2.0 branch May 16, 2024 02:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@englefly@xiaokang@hello-stephen