Uh oh!
There was an error while loading. Please reload this page.
[feature](function) support bitmap type in min/max_by agg function - #25430
Conversation
zhangstar333
commented
Oct 13, 2023
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
| } | ||
| } | ||
| void change(const IColumn& column, size_t row_num, Arena*) { |
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
| voidchange(constIColumn&column, size_trow_num, Arena*) { | |
| voidchange(constIColumn&column, size_trow_num, Arena*/*unused*/) { |
| value = assert_cast<const ColumnBitmap&>(column).get_data()[row_num]; | ||
| } | ||
| void change(const Self& to, Arena*) { |
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
| voidchange(constSelf&to, Arena*) { | |
| voidchange(constSelf&to, Arena*/*unused*/) { |
doris-robot
commented
Oct 13, 2023
TeamCity be ut coverage result: |
doris-robot
commented
Oct 13, 2023
(From new machine)TeamCity pipeline, clickbench performance test result: |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
wm1581066
commented
Oct 17, 2023
TT |
…25430) support bitmap type in min/max_by agg function
…pache#25430) support bitmap type in min/max_by agg function
…pache#25430) support bitmap type in min/max_by agg function
Proposed changes
support bitmap type in min/max_by agg function
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...