Skip to content

[fix](be)fix bug of converting outer join probe block to nullable - #25492

Merged
yiguolei merged 1 commit into
apache:masterfrom
starocean999:master_bug_0824
Oct 17, 2023
Merged

[fix](be)fix bug of converting outer join probe block to nullable#25492
yiguolei merged 1 commit into
apache:masterfrom
starocean999:master_bug_0824

Conversation

@starocean999

@starocean999starocean999 commented Oct 16, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

_do_evaluate will add temp result column into original table block, so in order to only convert correct columns to be nullable, need call convert_block_to_null before _do_evaluate

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@starocean999

starocean999 commented Oct 16, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@starocean999starocean999 changed the title [fix](be)confix bug of converting outer join probe block to nullable[fix](be)fix bug of converting outer join probe block to nullableOct 16, 2023
@github-actions

github-actionsBot commented Oct 16, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Oct 16, 2023

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.76% (8218/22357)
Line Coverage: 28.85% (65873/228336)
Region Coverage: 27.57% (34199/124048)
Branch Coverage: 24.25% (17398/71758)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2606a57176f1267648bb62047b32fa848b6a346c_2606a57176f1267648bb62047b32fa848b6a346c/report/index.html

@doris-robot

doris-robot commented Oct 16, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.54 seconds
stream load tsv: 569 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162284321 Bytes

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 17, 2023
@github-actions

github-actionsBot commented Oct 17, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Oct 17, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

yiguolei
yiguolei approved these changes Oct 17, 2023
View reviewed changes

@yiguoleiyiguolei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei
yiguolei merged commit ef7d8aa into apache:masterOct 17, 2023
@wm1581066wm1581066 added the usercase Important user case type label label Oct 17, 2023
@zhangstar333zhangstar333 mentioned this pull request Oct 19, 2023
Merged
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@starocean999王翔宇
[fix](be)confix bug of converting outer join probe block to nullable (a…
1090e31
…pache#25492)
_do_evaluate will add temp result column into original table block, so in order to only convert correct columns to be nullable, need call convert_block_to_null before _do_evaluate
@xiaokangxiaokang mentioned this pull request Dec 4, 2023
Closed
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@starocean999胥剑旭
[fix](be)confix bug of converting outer join probe block to nullable (a…
8030bad
…pache#25492)
_do_evaluate will add temp result column into original table block, so in order to only convert correct columns to be nullable, need call convert_block_to_null before _do_evaluate
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BiteTheDDDDtBiteTheDDDDtBiteTheDDDDt approved these changes
@yiguoleiyiguoleiyiguolei approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.3-mergedmerge_conflictpick_pipelinexreviewedusercaseImportant user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@starocean999@doris-robot@BiteTheDDDDt@yiguolei@xiaokang@wm1581066