Skip to content

[fix](backup) fix backup fail on s3 - #25496

Merged
morningman merged 2 commits into
apache:masterfrom
morningman:backup_to_s3_pr
Oct 18, 2023
Merged

[fix](backup) fix backup fail on s3#25496
morningman merged 2 commits into
apache:masterfrom
morningman:backup_to_s3_pr

Conversation

@morningman

@morningmanmorningman commented Oct 16, 2023

Copy link
Copy Markdown
Contributor

Proposed changes

The s3 client properties are not passed to BE correctly.
The test cases will be added later

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morningmanmorningman added dev/2.0.3 usercase Important user case type label labels Oct 16, 2023
@morningman

morningman commented Oct 16, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@morningmanmorningman mentioned this pull request Oct 16, 2023
Closed
@doris-robot

doris-robot commented Oct 16, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.08 seconds
stream load tsv: 555 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162459857 Bytes

@github-actions

github-actionsBot commented Oct 17, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

wsjz
wsjz approved these changes Oct 17, 2023
View reviewed changes

@wsjzwsjz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman

morningman commented Oct 17, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Oct 17, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.48 seconds
stream load tsv: 554 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162299825 Bytes

wsjz
wsjz approved these changes Oct 17, 2023
View reviewed changes

@wsjzwsjz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 18, 2023
@morningman
morningman merged commit db16a14 into apache:masterOct 18, 2023
xiaokang pushed a commit that referenced this pull request Oct 18, 2023
@morningman@xiaokang
[fix](backup) fix backup fail on s3 (#25496)
f3bb9b3
The s3 client properties are not passed to BE correctly.
The test cases will be added later
@morningmanmorningman mentioned this pull request Oct 23, 2023
Merged
AshinGau pushed a commit that referenced this pull request Oct 25, 2023
@morningman
[fix](backup) missing use_path_style properties for minio (#25803)
0dcbc5e
Follow #25496.
In #25496, I fixed the issue that the aws s3 properties are invalid when passing from FE to BE.
But it missed the `use_path_style` property, which is useful for minio access.
This PR fix it.
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@morningman王翔宇
[fix](backup) fix backup fail on s3 (apache#25496)
1c4a48d
The s3 client properties are not passed to BE correctly.
The test cases will be added later
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@morningman王翔宇
[fix](backup) missing use_path_style properties for minio (apache#25803)
4addf4c
Follow apache#25496.
In apache#25496, I fixed the issue that the aws s3 properties are invalid when passing from FE to BE.
But it missed the `use_path_style` property, which is useful for minio access.
This PR fix it.
@xiaokangxiaokang mentioned this pull request Dec 4, 2023
Closed
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@morningman胥剑旭
[fix](backup) fix backup fail on s3 (apache#25496)
9fdfffb
The s3 client properties are not passed to BE correctly.
The test cases will be added later
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@morningman胥剑旭
[fix](backup) missing use_path_style properties for minio (apache#25803)
744c8dd
Follow apache#25496.
In apache#25496, I fixed the issue that the aws s3 properties are invalid when passing from FE to BE.
But it missed the `use_path_style` property, which is useful for minio access.
This PR fix it.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@w41terw41terw41ter approved these changes
@AshinGauAshinGauAshinGau approved these changes
+1 more reviewer
@wsjzwsjzwsjz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.3-mergedreviewedusercaseImportant user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@morningman@doris-robot@w41ter@wsjz@AshinGau@xiaokang