Skip to content

[fix](Nereids) add int type alias 'integer' - #25509

Merged
xiaokang merged 1 commit into
apache:branch-2.0from
morrySnow:add_integer
Oct 17, 2023
Merged

[fix](Nereids) add int type alias 'integer'#25509
xiaokang merged 1 commit into
apache:branch-2.0from
morrySnow:add_integer

Conversation

@morrySnow

Copy link
Copy Markdown
Contributor

cherry-pick from master
PR: #25376
commit id: 934d828

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@xiaokangxiaokang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaokang
xiaokang merged commit 1be3790 into apache:branch-2.0Oct 17, 2023
@morrySnow
morrySnow deleted the add_integer branch October 17, 2023 08:50
Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request May 28, 2026
### What problem does this PR solve?
Issue Number: closeapache#25509
Related PR: apache#61248
Problem Summary: S3/OSS prefetch timeout can cancel and close PrefetchBufferedReader while an async PrefetchBuffer task is still running. The task kept PrefetchBuffer alive but only stored the underlying FileReader as a raw pointer, so the owner could destroy the reader before the async task resumed on the error path and logged reader metadata. Keep a shared FileReader reference in each PrefetchBuffer so the async prefetch task cannot outlive the reader it dereferences, and add a unit test that covers close timeout while the prefetch read is blocked.
### Release note
None
### Check List (For Author)
- Test: git diff --check; git diff --cached --check; attempted build-support/clang-format.sh and build-support/check-format.sh but llvm@16/clang-format is not installed; attempted ./run-be-ut.sh --run buffered_reader_test but it failed before running tests because JAVA_HOME points to JDK 11 and JDK_17 is not set
- Behavior changed: No
- Does this need documentation: No
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@morrySnow@xiaokang