Skip to content

[chore](compaction) Do not print the stack trace when the compaction task already exists - #25597

Merged
dataroaring merged 2 commits into
apache:masterfrom
Xiaoccer:compaction_status
Oct 18, 2023
Merged

[chore](compaction) Do not print the stack trace when the compaction task already exists#25597
dataroaring merged 2 commits into
apache:masterfrom
Xiaoccer:compaction_status

Conversation

@Xiaoccer

@XiaoccerXiaoccer commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@Xiaoccer

Xiaoccer commented Oct 18, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions

github-actionsBot commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

dataroaring
dataroaring approved these changes Oct 18, 2023
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring

dataroaring commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

run buildall

@doris-robot

doris-robot commented Oct 18, 2023

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.00% (8277/22369)
Line Coverage: 29.07% (66384/228342)
Region Coverage: 27.73% (34453/124259)
Branch Coverage: 24.35% (17509/71914)
Coverage Report: http://coverage.selectdb-in.cc/coverage/fbb9f183312e0d76e8398ef12e2529a97553feeb_fbb9f183312e0d76e8398ef12e2529a97553feeb/report/index.html

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 18, 2023
@github-actions

github-actionsBot commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@doris-robot

doris-robot commented Oct 18, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.89 seconds
stream load tsv: 563 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162282642 Bytes

@doris-robot

doris-robot commented Oct 18, 2023

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.00% (8277/22369)
Line Coverage: 29.07% (66382/228342)
Region Coverage: 27.73% (34453/124259)
Branch Coverage: 24.35% (17508/71914)
Coverage Report: http://coverage.selectdb-in.cc/coverage/31f2483170d5d4d06f76ff0a1b84685f5c7d7f8f_31f2483170d5d4d06f76ff0a1b84685f5c7d7f8f/report/index.html

@doris-robot

doris-robot commented Oct 18, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.38 seconds
stream load tsv: 561 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162279494 Bytes

yiguolei
yiguolei approved these changes Oct 18, 2023
View reviewed changes

@yiguoleiyiguolei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguoleiyiguolei added the usercase Important user case type label label Oct 18, 2023
airborne12
airborne12 approved these changes Oct 18, 2023
View reviewed changes

@airborne12airborne12 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
dataroaring merged commit 32fc8a1 into apache:masterOct 18, 2023
xiaokang pushed a commit that referenced this pull request Oct 22, 2023
@Xiaoccer@xiaokang
[chore](compaction) Do not print the stack trace when the compaction …
3f5dfbe
…task already exists (#25597)
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@Xiaoccer王翔宇
[chore](compaction) Do not print the stack trace when the compaction …
2ab790b
…task already exists (apache#25597)
@xiaokangxiaokang mentioned this pull request Dec 4, 2023
Closed
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@Xiaoccer胥剑旭
[chore](compaction) Do not print the stack trace when the compaction …
ed7da7c
…task already exists (apache#25597)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@airborne12airborne12airborne12 approved these changes
@yiguoleiyiguoleiyiguolei approved these changes
@dataroaringdataroaringdataroaring approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.3-mergedreviewedusercaseImportant user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Xiaoccer@dataroaring@doris-robot@airborne12@yiguolei@xiaokang