Skip to content

[fix](multi-table) fix unknown source slot descriptor when load multi table - #25762

Merged
dataroaring merged 4 commits into
apache:masterfrom
sollhui:multi_table
Oct 25, 2023
Merged

[fix](multi-table) fix unknown source slot descriptor when load multi table#25762
dataroaring merged 4 commits into
apache:masterfrom
sollhui:multi_table

Conversation

@sollhui

@sollhuisollhui commented Oct 23, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

Bug

image

when use one single multi table load to load data to multi tables, it can not load successfully for unknown source slot descriptor.

Reason

The reason why 'unknown source slot descriptor' is multi table shared one descriptor when load.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@sollhui

sollhui commented Oct 23, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Oct 23, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@sollhui

sollhui commented Oct 23, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Oct 23, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@sollhuisollhui changed the title (improvement)(multi-table) support multi table load[improvement](multi-table) support multi table loadOct 23, 2023
@doris-robot

doris-robot commented Oct 23, 2023

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.03% (8298/22410)
Line Coverage: 29.16% (66621/228433)
Region Coverage: 27.76% (34616/124708)
Branch Coverage: 24.41% (17578/72016)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f5fcb2f1cef6fc3b55685be4ebcc9268d63fc274_f5fcb2f1cef6fc3b55685be4ebcc9268d63fc274/report/index.html

@doris-robot

doris-robot commented Oct 23, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.09 seconds
stream load tsv: 554 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162010907 Bytes

@sollhui

sollhui commented Oct 25, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Oct 25, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

freemandealer
freemandealer requested changes Oct 25, 2023
View reviewed changes
Comment threadbe/src/pipeline/pipeline_fragment_context.cpp
@sollhui

sollhui commented Oct 25, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

freemandealer
freemandealer approved these changes Oct 25, 2023
View reviewed changes

@freemandealerfreemandealer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Oct 25, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@github-actions

github-actionsBot commented Oct 25, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Oct 25, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.28 seconds
stream load tsv: 555 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 34 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162212686 Bytes

@sollhuisollhui changed the title [improvement](multi-table) support multi table load[fix](multi-table) fix unknown source slot descriptor when load multi tableOct 25, 2023
@sollhui

sollhui commented Oct 25, 2023

Copy link
Copy Markdown
ContributorAuthor

run clickbench

@doris-robot

doris-robot commented Oct 25, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.31 seconds
stream load tsv: 556 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size: 17162141846 Bytes

dataroaring
dataroaring approved these changes Oct 25, 2023
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 25, 2023
@github-actions

github-actionsBot commented Oct 25, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@dataroaringdataroaring added the usercase Important user case type label label Oct 25, 2023
@dataroaring
dataroaring merged commit e783ef7 into apache:masterOct 25, 2023
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@sollhui王翔宇
[fix](multi-table) fix unknown source slot descriptor when load multi…
c9e3db7
… table (apache#25762)
@sollhuisollhui mentioned this pull request Nov 1, 2023
Merged
xiaokang pushed a commit that referenced this pull request Nov 1, 2023
@sollhui
[branch-2.0][fix](multi-table) fix unknown source slot descriptor whe…
a35de81
…n load multi table (#25762) (#26223)
gnehil pushed a commit to gnehil/doris that referenced this pull request Dec 4, 2023
@sollhuignehil
[branch-2.0][fix](multi-table) fix unknown source slot descriptor whe…
98d7076
…n load multi table (apache#25762) (apache#26223)
@xiaokangxiaokang mentioned this pull request Dec 4, 2023
Closed
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@sollhui胥剑旭
[fix](multi-table) fix unknown source slot descriptor when load multi…
9520e1d
… table (apache#25762)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freemandealerfreemandealerfreemandealer approved these changes
@dataroaringdataroaringdataroaring approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.3-mergedmerge_conflictreviewedusercaseImportant user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sollhui@doris-robot@freemandealer@dataroaring@xiaokang