Skip to content

[Bug](materialized-view) add limit for group by with float/double on create mv - #25823

Merged
BiteTheDDDDt merged 1 commit into
apache:masterfrom
BiteTheDDDDt:dev_1024
Oct 24, 2023
Merged

[Bug](materialized-view) add limit for group by with float/double on create mv#25823
BiteTheDDDDt merged 1 commit into
apache:masterfrom
BiteTheDDDDt:dev_1024

Conversation

@BiteTheDDDDt

Copy link
Copy Markdown
Contributor

Proposed changes

doris do not support float/double key type on storage engine.

*** Query id: 0-0 ***
*** tablet id: 0 ***
*** Aborted at 1698114021 (unix time) try"date -d @1698114021"if you are usingGNU date ***
*** Current BE git commitID: 29b4448635 ***
*** SIGSEGV address not mapped to object (@0x0) received by PID 737595 (TID740061OR0x7f0f225ff700) from PID 0; stack trace: ***
0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /mnt/disk2/liyuanyuan/enterprise-core/2.2.0.2/enterprise-core/be/src/common/signal_handler.h:4171# os::Linux::chained_handler(int, siginfo*, void*) in /mnt/disk2/liyuanyuan/ldb/jdk8/jre/lib/amd64/server/libjvm.so
2# JVM_handle_linux_signal in /mnt/disk2/liyuanyuan/ldb/jdk8/jre/lib/amd64/server/libjvm.so
3# signalHandler(int, siginfo*, void*) in /mnt/disk2/liyuanyuan/ldb/jdk8/jre/lib/amd64/server/libjvm.so
4# 0x00007F115F086B50 in /lib64/libc.so.65# doris::segment_v2::SegmentWriter::_full_encode_keys[abi:cxx11](std::vector<doris::vectorized::IOlapColumnDataAccessor*, std::allocator<doris::vectorized::IOlapColumnDataAccessor*> > const&, unsignedlong, bool) at /mnt/disk2/liyuanyuan/enterprise-core/2.2.0.2/enterprise-core/be/src/olap/rowset/segment_v2/segment_writer.cpp:7436# doris::segment_v2::SegmentWriter::append_block(doris::vectorized::Block const*, unsignedlong, unsignedlong) at /mnt/disk2/liyuanyuan/enterprise-core/2.2.0.2/enterprise-core/be/src/olap/rowset/segment_v2/segment_writer.cpp:6967# doris::BetaRowsetWriter::_do_add_block(doris::vectorized::Block const*, std::unique_ptr<doris::segment_v2::SegmentWriter, std::default_delete<doris::segment_v2::SegmentWriter> >*, unsignedlong, unsignedlong) at /mnt/disk2/liyuanyuan/enterprise-core/2.2.0.2/enterprise-core/be/src/olap/rowset/beta_rowset_writer.cpp:3928# doris::BetaRowsetWriter::_add_block(doris::vectorized::Block const*, std::unique_ptr<doris::segment_v2::SegmentWriter, std::default_delete<doris::segment_v2::SegmentWriter> >*, doris::FlushContext const*) at /mnt/disk2/liyuanyuan/enterprise-core/2.2.0.2/enterprise-core/be/src/olap/rowset/beta_rowset_writer.cpp:4089# doris::BetaRowsetWriter::flush_single_memtable(doris::vectorized::Block const*, long*, doris::FlushContext const*) at /mnt/disk2/liyuanyuan/enterprise-core/2.2.0.2/enterprise-core/be/src/olap/rowset/beta_rowset_writer.cpp:47210# doris::MemTable::_do_flush() at /mnt/disk2/liyuanyuan/enterprise-core/2.2.0.2/enterprise-core/be/src/olap/memtable.cpp:54011# doris::MemTable::flush() at /mnt/disk2/liyuanyuan/enterprise-core/2.2.0.2/enterprise-core/be/src/olap/memtable.cpp:50312# doris::FlushToken::_flush_memtable(doris::MemTable*, long) at /mnt/disk2/liyuanyuan/enterprise-core/2.2.0.2/enterprise-core/be/src/olap/memtable_flush_executor.cpp:9913# doris::MemtableFlushTask::run() at /mnt/disk2/liyuanyuan/enterprise-core/2.2.0.2/enterprise-core/be/src/olap/memtable_flush_executor.cpp:4714# doris::ThreadPool::dispatch_thread() in /mnt/disk2/liyuanyuan/enterprise-core/2.2.0.2/selectdb-doris-2.0.2-ikas/be/lib/doris_be
15# doris::Thread::supervise_thread(void*) at /mnt/disk2/liyuanyuan/enterprise-core/2.2.0.2/enterprise-core/be/src/util/thread.cpp:47016# start_thread in /lib64/libpthread.so.017# __clone in /lib64/libc.so.6

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@BiteTheDDDDt

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.48 seconds
stream load tsv: 551 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 23 seconds loaded 2358488459 Bytes, about 97 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17161914623 Bytes

@HappenLeeHappenLee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 24, 2023
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@BiteTheDDDDt
BiteTheDDDDt merged commit 091cb0c into apache:masterOct 24, 2023
xiaokang pushed a commit that referenced this pull request Oct 24, 2023
…create mv (#25823)
doris do not support float/double key type on storage engine.
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
…create mv (apache#25823)
doris do not support float/double key type on storage engine.
gnehil pushed a commit to gnehil/doris that referenced this pull request Dec 4, 2023
…create mv (apache#25823)
doris do not support float/double key type on storage engine.
@xiaokangxiaokang mentioned this pull request Dec 4, 2023
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
…create mv (apache#25823)
doris do not support float/double key type on storage engine.
@BiteTheDDDDt
BiteTheDDDDt deleted the dev_1024 branch January 20, 2025 06:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.3-mergedp0_creviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@BiteTheDDDDt@doris-robot@HappenLee@Mryange@xiaokang