Skip to content

[feature-wip](arrow-flight)(step4) Support other DML and DDL statements, besides Select - #25919

Merged
xinyiZzz merged 2 commits into
apache:masterfrom
xinyiZzz:20231016_support_session_veriable_flight
Nov 8, 2023
Merged

[feature-wip](arrow-flight)(step4) Support other DML and DDL statements, besides Select#25919
xinyiZzz merged 2 commits into
apache:masterfrom
xinyiZzz:20231016_support_session_veriable_flight

Conversation

@xinyiZzz

@xinyiZzzxinyiZzz commented Oct 25, 2023

Copy link
Copy Markdown
Contributor

Proposed changes

Design Documentation Linked to #25514

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@xinyiZzz
xinyiZzz marked this pull request as draft October 25, 2023 14:26
@xinyiZzz
xinyiZzzforce-pushed the 20231016_support_session_veriable_flight branch 2 times, most recently from 74942f8 to 267c526CompareOctober 30, 2023 08:52
yiguolei
yiguolei reviewed Oct 31, 2023
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/mysql/MysqlChannel.java Outdated
yiguolei
yiguolei reviewed Oct 31, 2023
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/mysql/MysqlChannel.java Outdated
yiguolei
yiguolei reviewed Oct 31, 2023
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java
yiguolei
yiguolei reviewed Oct 31, 2023
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/qe/ConnectProcessor.java
github-actions[bot]
github-actionsBot reviewed Nov 1, 2023
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadbe/src/runtime/result_buffer_mgr.cpp
@xinyiZzz
xinyiZzz marked this pull request as ready for review November 2, 2023 01:29
@xinyiZzz

xinyiZzz commented Nov 2, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@xinyiZzz
xinyiZzzforce-pushed the 20231016_support_session_veriable_flight branch from d1fcb74 to 68e0cfaCompareNovember 2, 2023 09:28
@xinyiZzz

xinyiZzz commented Nov 2, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@xinyiZzz
xinyiZzzforce-pushed the 20231016_support_session_veriable_flight branch from 2d30cd9 to b4d9fdaCompareNovember 2, 2023 13:05
@xinyiZzz

xinyiZzz commented Nov 2, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Nov 2, 2023

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.28% (8452/22669)
Line Coverage: 29.68% (68431/230578)
Region Coverage: 28.33% (35407/124964)
Branch Coverage: 25.07% (18072/72074)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b4d9fda98053ddc201ca0ff969b076a89ff31a4c_b4d9fda98053ddc201ca0ff969b076a89ff31a4c/report/index.html

@xinyiZzz

xinyiZzz commented Nov 3, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

github-actions[bot]
github-actionsBot reviewed Nov 3, 2023
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadbe/src/runtime/result_buffer_mgr.h Outdated
@xinyiZzz

xinyiZzz commented Nov 3, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Nov 3, 2023

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.29% (8452/22666)
Line Coverage: 29.68% (68437/230621)
Region Coverage: 28.34% (35414/124974)
Branch Coverage: 25.07% (18073/72080)
Coverage Report: http://coverage.selectdb-in.cc/coverage/42702411f83cb7be6da384598ce7a84444b828ab_42702411f83cb7be6da384598ce7a84444b828ab/report/index.html

@xinyiZzz

xinyiZzz commented Nov 3, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

github-actions[bot]
github-actionsBot reviewed Nov 3, 2023
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadbe/src/runtime/result_buffer_mgr.cpp
@doris-robot

doris-robot commented Nov 3, 2023

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.30% (8454/22666)
Line Coverage: 29.68% (68457/230625)
Region Coverage: 28.35% (35426/124979)
Branch Coverage: 25.08% (18077/72084)
Coverage Report: http://coverage.selectdb-in.cc/coverage/893e1a29643c577a061b8349f1bc041d16f936d6_893e1a29643c577a061b8349f1bc041d16f936d6/report/index.html

@doris-robot

doris-robot commented Nov 3, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.58 seconds
stream load tsv: 558 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162116387 Bytes

yiguolei
yiguolei reviewed Nov 5, 2023
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/mysql/MysqlProto.java Outdated
yiguolei
yiguolei reviewed Nov 5, 2023
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java
yiguolei
yiguolei reviewed Nov 5, 2023
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/qe/QueryState.java Outdated
@xinyiZzz
xinyiZzzforce-pushed the 20231016_support_session_veriable_flight branch from 893e1a2 to f178572CompareNovember 5, 2023 16:08
@xinyiZzz

xinyiZzz commented Nov 5, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Nov 5, 2023

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.29% (8452/22667)
Line Coverage: 29.68% (68442/230636)
Region Coverage: 28.33% (35408/124980)
Branch Coverage: 25.07% (18075/72084)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f178572d22f6371c78562d92d7f66c0115e9ae02_f178572d22f6371c78562d92d7f66c0115e9ae02/report/index.html

@xinyiZzz
xinyiZzzforce-pushed the 20231016_support_session_veriable_flight branch from f178572 to 5328810CompareNovember 5, 2023 17:02
@xinyiZzz

xinyiZzz commented Nov 5, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Nov 5, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.16 seconds
stream load tsv: 574 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 34 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162362181 Bytes

@doris-robot

doris-robot commented Nov 5, 2023

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.30% (8454/22667)
Line Coverage: 29.68% (68455/230636)
Region Coverage: 28.34% (35417/124980)
Branch Coverage: 25.08% (18079/72084)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5328810b31d85ade7ca10939e31f6a3c4beaf4ff_5328810b31d85ade7ca10939e31f6a3c4beaf4ff/report/index.html

@doris-robot

doris-robot commented Nov 5, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.58 seconds
stream load tsv: 576 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162621155 Bytes

yiguolei
yiguolei approved these changes Nov 7, 2023
View reviewed changes

@yiguoleiyiguolei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Nov 7, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Nov 7, 2023
@github-actions

github-actionsBot commented Nov 7, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@xinyiZzz
xinyiZzz merged commit 1544110 into apache:masterNov 8, 2023
seawinde pushed a commit to seawinde/doris that referenced this pull request Nov 8, 2023
@xinyiZzz@seawinde
[feature-wip](arrow-flight)(step4) Support other DML and DDL statemen…
3794034
…ts, besides `Select` (apache#25919)
Design Documentation Linked to apache#25514
seawinde pushed a commit to seawinde/doris that referenced this pull request Nov 13, 2023
@xinyiZzz@seawinde
[feature-wip](arrow-flight)(step4) Support other DML and DDL statemen…
41931f7
…ts, besides `Select` (apache#25919)
Design Documentation Linked to apache#25514
@xinyiZzzxinyiZzz mentioned this pull request Dec 1, 2023
Closed
1 task
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@xinyiZzz胥剑旭
[feature-wip](arrow-flight)(step4) Support other DML and DDL statemen…
cd5b7a5
…ts, besides `Select` (apache#25919)
Design Documentation Linked to apache#25514
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments
@yiguoleiyiguoleiyiguolei approved these changes
@zclllyybbzclllyybbzclllyybb approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xinyiZzz@doris-robot@yiguolei@zclllyybb