Skip to content

[refactor & pipelineX][pick fix] Pick fix of predicate pushdown to pipelineX - #25953

Merged
Gabriel39 merged 1 commit into
apache:masterfrom
RoanHeNaN:pipelineX-1
Oct 26, 2023
Merged

[refactor & pipelineX][pick fix] Pick fix of predicate pushdown to pipelineX#25953
Gabriel39 merged 1 commit into
apache:masterfrom
RoanHeNaN:pipelineX-1

Conversation

@RoanHeNaN

@RoanHeNaNRoanHeNaN commented Oct 26, 2023

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

sh-checker report

To get the full details, please check in the job output.

shellcheck errors
'shellcheck ' found no issues.
shfmt errors

'shfmt ' returned error 1 finding the following formatting issues:
----------
--- build.sh.orig
+++ build.sh
@@ -532,9 +532,9 @@
-DDORIS_JAVA_HOME="${JAVA_HOME}" \
"${DORIS_HOME}/be"
- "${BUILD_SYSTEM}" -j "${PARALLEL}" - # 不要 install,这样确保 workspace 的 debug 跟 release 可以使用软连接到不同的二进制
- # "${BUILD_SYSTEM}" install
+ "${BUILD_SYSTEM}" -j "${PARALLEL}"
+ # 不要 install,这样确保 workspace 的 debug 跟 release 可以使用软连接到不同的二进制
+ # "${BUILD_SYSTEM}" install
cd "${DORIS_HOME}"
fi
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename

@RoanHeNaN
RoanHeNaN marked this pull request as ready for review October 26, 2023 08:03
@RoanHeNaN

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Co-authored-by: JackDrogon <jack.xsuperman@gmail.com>
@RoanHeNaN

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.78 seconds
stream load tsv: 556 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162225755 Bytes

@doris-robot

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.38 seconds
stream load tsv: 559 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 34 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162240096 Bytes

@Gabriel39Gabriel39 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 26, 2023
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@Gabriel39
Gabriel39 merged commit c352767 into apache:masterOct 26, 2023
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
…pelineX (apache#25953)
Co-authored-by: JackDrogon <jack.xsuperman@gmail.com>
@RoanHeNaN
RoanHeNaN deleted the pipelineX-1 branch October 30, 2023 10:59
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
…pelineX (apache#25953)
Co-authored-by: JackDrogon <jack.xsuperman@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@RoanHeNaN@doris-robot@BiteTheDDDDt@Gabriel39