[Fix](from_unixtime) Keep consistent with MySQL & bug fix by RoanHeNaN · Pull Request #25966 · apache/doris

RoanHeNaN · 2023-10-26T11:01:27Z

Bug fix: implicit convert from int32 -> int64 makes negative time stamp valid, so change signature to int64
Consistent: keep consistent with mysql.

Not merge to 2.0, because it changed function signature.

RoanHeNaN · 2023-10-26T11:04:03Z

run buildall

github-actions

clang-tidy made some suggestions

github-actions

clang-tidy made some suggestions

doris-robot · 2023-10-26T11:37:00Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.02 seconds
stream load tsv: 558 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.6 seconds inserted 10000000 Rows, about 349K ops/s
storage size: 17162132285 Bytes

RoanHeNaN · 2023-10-30T02:18:42Z

run buildall

doris-robot · 2023-10-30T03:00:59Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.9 seconds
stream load tsv: 552 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162216693 Bytes

RoanHeNaN · 2023-10-30T04:16:30Z

run buildall

doris-robot · 2023-10-30T04:52:04Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.99 seconds
stream load tsv: 552 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162354505 Bytes

RoanHeNaN · 2023-10-30T10:11:28Z

run buildall

doris-robot · 2023-10-30T10:32:41Z

TeamCity be ut coverage result:
Function Coverage: 37.38% (8471/22660)
Line Coverage: 29.66% (68513/230964)
Region Coverage: 28.25% (35595/126016)
Branch Coverage: 25.11% (18218/72564)
Coverage Report: http://coverage.selectdb-in.cc/coverage/27b8838493fdd0a95d13910f445c35693618785e_27b8838493fdd0a95d13910f445c35693618785e/report/index.html

doris-robot · 2023-10-30T10:55:04Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.55 seconds
stream load tsv: 556 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.9 seconds inserted 10000000 Rows, about 334K ops/s
storage size: 17162246514 Bytes

RoanHeNaN · 2023-10-30T13:02:50Z

run buildall

doris-robot · 2023-10-30T13:31:13Z

TeamCity be ut coverage result:
Function Coverage: 37.37% (8469/22665)
Line Coverage: 29.66% (68527/231005)
Region Coverage: 28.24% (35585/126024)
Branch Coverage: 25.11% (18221/72566)
Coverage Report: http://coverage.selectdb-in.cc/coverage/400af89f62f65b99dd596655109ffe8c17149f21_400af89f62f65b99dd596655109ffe8c17149f21/report/index.html

doris-robot · 2023-10-30T13:42:01Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.19 seconds
stream load tsv: 554 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17161969784 Bytes

RoanHeNaN · 2023-10-31T01:33:24Z

run buildall

doris-robot · 2023-10-31T02:30:15Z

TeamCity be ut coverage result:
Function Coverage: 37.37% (8471/22665)
Line Coverage: 29.68% (68565/231023)
Region Coverage: 28.25% (35602/126043)
Branch Coverage: 25.12% (18231/72578)
Coverage Report: http://coverage.selectdb-in.cc/coverage/bac0b2ee40b8542229b888c3cbfa790a14257b14_bac0b2ee40b8542229b888c3cbfa790a14257b14/report/index.html

doris-robot · 2023-10-31T02:59:47Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46 seconds
stream load tsv: 555 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162019731 Bytes

starocean999 · 2023-10-31T04:57:34Z

 public static StringLiteral fromUnixTime(LiteralExpr unixTime) throws AnalysisException {
 // if unixTime < 0, we should return null, throw a exception and let BE process
- if (unixTime.getLongValue() < 0 || unixTime.getLongValue() >= Integer.MAX_VALUE) {
+ if (unixTime.getLongValue() < 0 || unixTime.getLongValue() > 32536771199L) {


pls add some comment about the magic number 32536771199L as in nereids

yiguolei

LGTM

yiguolei · 2023-10-31T05:20:56Z

run buildall

github-actions · 2023-10-31T05:21:47Z

PR approved by at least one committer and no changes requested.

github-actions · 2023-10-31T05:21:50Z

PR approved by anyone and no changes requested.

doris-robot · 2023-10-31T05:43:42Z

TeamCity be ut coverage result:
Function Coverage: 37.37% (8471/22665)
Line Coverage: 29.68% (68563/231032)
Region Coverage: 28.25% (35607/126043)
Branch Coverage: 25.11% (18227/72578)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d8485b90ce778227d156e3d5ab62640f2092383f_d8485b90ce778227d156e3d5ab62640f2092383f/report/index.html

doris-robot · 2023-10-31T05:56:05Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.19 seconds
stream load tsv: 576 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 34 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162384304 Bytes

Bug fix: implicit convert from int32 -> int64 makes negative time stamp valid, so change signature to int64 Consistent: keep consistent with mysql.

…28649) Bug fix: implicit convert from int32 -> int64 makes negative time stamp valid, so change signature to int64 Consistent: keep consistent with mysql.

Bug fix: implicit convert from int32 -> int64 makes negative time stamp valid, so change signature to int64 Consistent: keep consistent with mysql.

RoanHeNaN added 2 commits October 26, 2023 18:55

N
a5a3fcf

Format
6c29a72

github-actionsBot reviewed Oct 26, 2023
View reviewed changes

Comment threadbe/src/vec/functions/date_time_transforms.h

github-actionsBot reviewed Oct 26, 2023
View reviewed changes

Comment threadbe/src/vec/functions/date_time_transforms.h

RoanHeNaN added 2 commits October 27, 2023 10:34

Fe fold
b5d2b99

rm cast double regression
e312742

rg
dc727a7

RoanHeNaN added 3 commits October 30, 2023 18:09

fix be ut
dccd44f

N
a506807

need
27b8838

RoanHeNaN force-pushed the from_times branch from c7dede0 to 27b8838Compare October 30, 2023 10:09

Fix RT
400af89

Fix RG
bac0b2e

starocean999 reviewed Oct 31, 2023
View reviewed changes

Add comment for magic number
d8485b9

yiguolei approved these changes Oct 31, 2023
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 31, 2023

github-actionsBot added the reviewed label Oct 31, 2023

starocean999 approved these changes Oct 31, 2023
View reviewed changes

yiguolei merged commit 0449a24 into apache:masterOct 31, 2023

RoanHeNaN deleted the from_times branch October 31, 2023 10:09

wm1581066 added dev/2.0.4 usercase Important user case type label labels Dec 19, 2023

xiaokang mentioned this pull request Dec 19, 2023
[Fix](from_unixtime) Keep consistent with MySQL & bug fix (#25966) #28649
Merged

xiaokang added dev/2.0.4-merged and removed dev/2.0.4 labels Dec 19, 2023

Uh oh!

Conversation

RoanHeNaN commented Oct 26, 2023• edited by yiguolei Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RoanHeNaN commented Oct 26, 2023

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

doris-robot commented Oct 26, 2023

Uh oh!

RoanHeNaN commented Oct 30, 2023

Uh oh!

doris-robot commented Oct 30, 2023

Uh oh!

RoanHeNaN commented Oct 30, 2023

Uh oh!

doris-robot commented Oct 30, 2023

Uh oh!

RoanHeNaN commented Oct 30, 2023

Uh oh!

doris-robot commented Oct 30, 2023

Uh oh!

doris-robot commented Oct 30, 2023

Uh oh!

RoanHeNaN commented Oct 30, 2023

Uh oh!

doris-robot commented Oct 30, 2023

Uh oh!

doris-robot commented Oct 30, 2023

Uh oh!

RoanHeNaN commented Oct 31, 2023

Uh oh!

doris-robot commented Oct 31, 2023

Uh oh!

doris-robot commented Oct 31, 2023

Uh oh!

starocean999Oct 31, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RoanHeNaNOct 31, 2023

Choose a reason for hiding this comment

Uh oh!

yiguolei left a comment

Choose a reason for hiding this comment

Uh oh!

yiguolei commented Oct 31, 2023

Uh oh!

github-actionsBot commented Oct 31, 2023

Uh oh!

github-actionsBot commented Oct 31, 2023

Uh oh!

doris-robot commented Oct 31, 2023

Uh oh!

doris-robot commented Oct 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

RoanHeNaN commented Oct 26, 2023•
edited by yiguolei
Loading

starocean999Oct 31, 2023•
edited
Loading